Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pENJg-0008TK-4x for pgsql-hackers@arkaria.postgresql.org; Sun, 08 Jan 2023 04:29:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pENJd-0000hE-4e for pgsql-hackers@arkaria.postgresql.org; Sun, 08 Jan 2023 04:29:49 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pENJc-0000h4-I2 for pgsql-hackers@lists.postgresql.org; Sun, 08 Jan 2023 04:29:48 +0000 Received: from janus.karlpinc.com ([173.161.46.12] helo=smtp.karlpinc.com) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pENJV-00044X-Fi for pgsql-hackers@postgresql.org; Sun, 08 Jan 2023 04:29:46 +0000 Received: from slate.karlpinc.com (unknown [192.168.1.14]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by smtp.karlpinc.com (Postfix) with ESMTPS id 49C5FA030; Sat, 7 Jan 2023 22:29:38 -0600 (CST) Received: from slate.karlpinc.com (localhost [IPv6:::1]) by slate.karlpinc.com (Postfix) with ESMTPS id 17A1F3FB49; Sat, 7 Jan 2023 22:29:38 -0600 (CST) Date: Sat, 7 Jan 2023 22:29:35 -0600 From: "Karl O. Pinc" To: Tom Lane Cc: Peter Eisentraut , Daniel Gustafsson , Robert Haas , Andres Freund , Devrim =?UTF-8?B?R8O8bmTDvHo=?= , Joe Conway , PostgreSQL Hackers Subject: Re: drop postmaster symlink Message-ID: <20230107222935.5b63fad5@slate.karlpinc.com> In-Reply-To: <20230107195608.3f770868@slate.karlpinc.com> References: <252b8b14-dc3e-1c70-3da5-e59c1616f2ad@joeconway.com> <6b11c9efcd3a1d89719370224d84f8cd5e7b1a8c.camel@gunduz.org> <3705500.1669216069@sss.pgh.pa.us> <20221123195010.huuypoilx6lw7ceg@awork3.anarazel.de> <20230107165942.748ccf4e@slate.karlpinc.com> <3492787.1673134705@sss.pgh.pa.us> <20230107195608.3f770868@slate.karlpinc.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sat, 7 Jan 2023 19:56:08 -0600 "Karl O. Pinc" wrote: > On Sat, 07 Jan 2023 18:38:25 -0500 > Tom Lane wrote: > > > "Karl O. Pinc" writes: > > > This is a review of Peter's 2 patches. I see only 1 small > > > problem. ... > > Hmm ... I thought this patch was about getting rid of the > > admittedly-obsolete installed symlink. ... > No. It's about getting rid of the symlink. The only way I could think of to review a patch that removes something is to report all the places I looked where a reference to the symlink might be. Then report what I found each place I looked and report if there's a problem, or might be. That way the committer knows where I didn't look if there's more that needs removing. Apologies that this was not clear. Regards, Karl Free Software: "You don't pay back, you pay forward." -- Robert A. Heinlein