Date: Mon, 9 Jan 2023 09:45:39 -0800
From: Nathan Bossart <nathandbossart@gmail.com>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Maxim Orlov <orlovmg@gmail.com>, Andrew Dunstan <andrew@dunslane.net>,
	Michael Paquier <michael@paquier.xyz>, Tom Lane <tgl@sss.pgh.pa.us>,
	Isaac Morland <isaac.morland@gmail.com>,
	Justin Pryzby <pryzby@telsasoft.com>,
	Pavel Luzanov <p.luzanov@postgrespro.ru>,
	pgsql-hackers@postgresql.org
Subject: Re: add \dpS to psql
Message-ID: <20230109174539.GA1112921@nathanxps13>
References: <Y5K7MxuH7Bi+zU5V@paquier.xyz>
 <20221209184055.GA59417@nathanxps13>
 <20221209184411.GB59417@nathanxps13>
 <09d09155-7ed0-29e2-c51b-e5cce7e68bf0@dunslane.net>
 <20221212171822.GA202606@nathanxps13>
 <CACG=ezY=8r8730tK04tb-gEa-xOVueXw70_o8VWe=HkzceqNhA@mail.gmail.com>
 <20221228212612.GA4010186@nathanxps13>
 <CAEZATCWDMjxEVKmSj3QD+Expo4YALMN3dxZS-UwS7wqbyBXtWw@mail.gmail.com>
 <20230107003651.GA789289@nathanxps13>
 <CAEZATCVWxf5P+r4hrKcM8kX6_Y5gmD4OnH74kb2qiqiV3FwL9g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAEZATCVWxf5P+r4hrKcM8kX6_Y5gmD4OnH74kb2qiqiV3FwL9g@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20230109174539.GA1112921%40nathanxps13>
Precedence: bulk

On Sat, Jan 07, 2023 at 11:18:59AM +0000, Dean Rasheed wrote:
> It might be true that temp tables aren't usually interesting from a
> permissions point of view, but it's not hard to imagine situations
> where interesting things do happen. It's also probably the case that
> most users won't have many temp tables, so I don't think including
> them by default will be particularly intrusive.
> 
> Also, from a user perspective, I think it would be something of a POLA
> violation for \dp[S] and \dt[S] to include different sets of tables,
> though I appreciate that we do that now. There's nothing in the docs
> to indicate that that's the case.

Agreed.

> Anyway, I've pushed the v2 patch as-is. If anyone feels strongly
> enough that we should change its behaviour for temp tables, then we
> can still discuss that.

Thanks!

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com