Date: Mon, 16 Jan 2023 10:31:53 +0900 (JST)
Message-Id: <20230116.103153.304248162331209247.horikyota.ntt@gmail.com>
To: amit.kapila16@gmail.com
Cc: kuroda.hayato@fujitsu.com, dilipbalaut@gmail.com,
 pgsql-hackers@postgresql.org
Subject: Re: Exit walsender before confirming remote flush in logical
 replication
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: <CAA4eK1LmCfLcu2hV_NCL9m0iQaE9=g7f8ePj79da373haFdZ-A@mail.gmail.com>
References: <CAA4eK1+pD654+XnrPugYueh7Oh22EBGTr6dA_fS0+gPiHayG9A@mail.gmail.com>
	<TYAPR01MB5866E7B0583504FBDE6B60FAF5F29@TYAPR01MB5866.jpnprd01.prod.outlook.com>
	<CAA4eK1LmCfLcu2hV_NCL9m0iQaE9=g7f8ePj79da373haFdZ-A@mail.gmail.com>
User-Agent: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/20230116.103153.304248162331209247.horikyota.ntt%40gmail.com>
Precedence: bulk

At Fri, 13 Jan 2023 16:41:08 +0530, Amit Kapila <amit.kapila16@gmail.com> wrote in 
> Okay, but what happens in the case of physical replication when
> synchronous_commit = remote_apply? In that case, won't it ensure that
> apply has also happened? If so, then shouldn't the time delay feature
> also cause a similar problem for physical replication as well?

As written in another mail, WalSndDone doesn't honor
synchronous_commit. In other words, AFAIS walsender finishes not
waiting remote_apply.  The unapplied recods will be applied at the
next startup.

I didn't confirmed that behavior for myself, though..

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center