Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pHYCQ-0000ZD-9Q for pgsql-hackers@arkaria.postgresql.org; Mon, 16 Jan 2023 22:43:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pHYCP-0000h9-29 for pgsql-hackers@arkaria.postgresql.org; Mon, 16 Jan 2023 22:43:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pHYCO-0000h0-NG for pgsql-hackers@lists.postgresql.org; Mon, 16 Jan 2023 22:43:28 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pHYCM-0004yf-2E for pgsql-hackers@postgresql.org; Mon, 16 Jan 2023 22:43:28 +0000 Received: by mail-pl1-x629.google.com with SMTP id jl4so31677654plb.8 for ; Mon, 16 Jan 2023 14:43:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Nj4KiZ9AaBgxUXrwGXNmbbIg0DGlI70dBsA5uje8d5A=; b=Fp+FXktEISOx08BPFAVTDR3SBY/0/ClFY/XscWI03rEJAZGGSEwun237qVrACrnjiP MXMd1ghihRbSmCZ0y+KCze5ark803TqZFaYrft48mAM/7Ew2AuglWQMp+ww0akU6773b TlfIypBsjsjtv4M/9bksvX/wQtm9UGJhJtuzEuQ/vlF/w9v4iC57FtoP0theBKPSQ9Pj jMWi0TVMKRpeWfNy5cAk3/V9hk0U9jNjQA85CA/upJWcwGYemzdMHa+T1NlDxIuzizLP saRz/ULMQfENcTUAT7o6lN/vggSExTqnYeF4xWfIT1wP6o+5H4rqnNuvnbqNhdp/3z9Y 8zsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Nj4KiZ9AaBgxUXrwGXNmbbIg0DGlI70dBsA5uje8d5A=; b=XlKUyA/iyJOD+cNQiux9PxpjrANJOHLSakUlGqk1nPk4503vPsGiggS2gcAmhgTIzL pqrgmdl0/tqZaQVA/orAqK76Z27mJZ7S2DiCKdnD4Ig63lUnU8sl1CXn02Rfr6SMd1vr AFzSoxIllr5owXn0lfSKuTE0pnvj0pECoIhjOuilj8SoGTm2LgxZp65SgJh72xcwkoCC NkZoIcCyDaFjcA5s/5CEazZ3WHCgVe1dWD1bCpjwWx25ON6m91hIbYBshCoHdiJXoz/y OGkzItcATm5YWi/fVaNzY7C5xoKnLgKO6FCSwec8TMsIByHMd+XMINd7eAbFoIE59PDT XWSQ== X-Gm-Message-State: AFqh2kpUy64BYQYassAA3bbMkacvj8uH3zhh6Q+gmZ75WT9vviCdjty4 SkKVHZznyVC/smzNPjqnjj/gN8dBmjY= X-Google-Smtp-Source: AMrXdXvgq9c9dSAaF51lySsHOhtFIdtbgaaM2/4d6CeziIWjKQ2K358dtUojok2BjYDRNQb9IaBbYQ== X-Received: by 2002:a17:903:2581:b0:194:8ddc:7d0e with SMTP id jb1-20020a170903258100b001948ddc7d0emr39523plb.65.1673909003937; Mon, 16 Jan 2023 14:43:23 -0800 (PST) Received: from nathanxps13 ([50.47.162.83]) by smtp.gmail.com with ESMTPSA id b1-20020a170903228100b001892af9472esm7438497plh.261.2023.01.16.14.43.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 14:43:23 -0800 (PST) Date: Mon, 16 Jan 2023 14:43:21 -0800 From: Nathan Bossart To: Peter Eisentraut Cc: Tom Lane , pgsql-hackers Subject: Re: Refactor recordExtObjInitPriv() Message-ID: <20230116224321.GC2714038@nathanxps13> References: <504bc485-6bd6-dd1b-fe10-e7351aeb310d@enterprisedb.com> <20230112000437.GA2032194@nathanxps13> <54b13402-b8ab-406a-d9a6-3542124ad6cf@enterprisedb.com> <1136333.1673544050@sss.pgh.pa.us> <20230112174049.GA2047702@nathanxps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Jan 16, 2023 at 12:01:47PM +0100, Peter Eisentraut wrote: > I have updated the patch as you suggested and split out the aggregate issue > into a separate patch for clarity. LGTM -- Nathan Bossart Amazon Web Services: https://aws.amazon.com