Feedback-ID: id4a34324:Fastmail
Date: Thu, 19 Jan 2023 18:58:45 -0800
From: Andres Freund <andres@anarazel.de>
To: pgsql-hackers@postgresql.org
Cc: Robert Haas <robertmhaas@gmail.com>,
	Thomas Munro <thomas.munro@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Amit Langote <amitlangote09@gmail.com>
Subject: Re: Replace PROC_QUEUE / SHM_QUEUE with ilist.h
Message-ID: <20230120025845.zavnnjzsa3r2bp5f@awork3.anarazel.de>
References: <20221120055930.t6kl3tyivzhlrzu2@awork3.anarazel.de>
 <20221203181722.ib6fwzuorhktpmhz@awork3.anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221203181722.ib6fwzuorhktpmhz@awork3.anarazel.de>
Archived-At: <https://www.postgresql.org/message-id/20230120025845.zavnnjzsa3r2bp5f%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2022-12-03 10:17:22 -0800, Andres Freund wrote:
> On 2022-11-19 21:59:30 -0800, Andres Freund wrote:
> > In [1] Robert justifiably complained about the use of PROC_QUEUE. I've
> > previously been bothered by this in [2], but didn't get around to finishing
> > the patches.
> > 
> > One thing that made me hesitate was the naming of the function for a) checking
> > whether a dlist_node is a list, b) initializing and deleting nodes in a way to
> > allow for a).  My patch adds dlist_node_init(), dlist_delete_thoroughly() /
> > dlist_delete_from_thoroughly() / dclist_delete_from_thoroughly() and
> > dlist_node_is_detached().  Thomas proposed dlist_delete_and_reinit() and
> > dlist_node_is_linked() instead.
> 
> Any comments on these names? Otherwise I'm planning to push ahead with the
> names as is, lest I forget this patchset for another ~2 years.

Finally pushed, with some fairly minor additional cleanup. No more SHM_QUEUE,
yay!

Also, predicate.c really needs some love.

Greetings,

Andres Freund