Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIweQ-000087-43 for pgsql-hackers@arkaria.postgresql.org; Fri, 20 Jan 2023 19:02:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pIweO-0005qr-Re for pgsql-hackers@arkaria.postgresql.org; Fri, 20 Jan 2023 19:02:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIweO-0005qh-FQ for pgsql-hackers@lists.postgresql.org; Fri, 20 Jan 2023 19:02:08 +0000 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pIweM-0005s5-00 for pgsql-hackers@postgresql.org; Fri, 20 Jan 2023 19:02:08 +0000 Received: by mail-pg1-x530.google.com with SMTP id f3so4854667pgc.2 for ; Fri, 20 Jan 2023 11:02:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YdmBi9RCPi2M/mRVqHoLZJEZLt0wcJEBSae7OLzaLcY=; b=G2AiQnub1BvvDjGIoSKOyKao1BXqkkd9edlowfufxJmxbQqQlAS6UhfyGbMc7XsFla MRWE44hjeih2+4+0TWr5hjRMkIwWL5D85Vn4SxnVW+TvaQqSpV1EiWGT9PN99Gxl9eKR hYA+G3JRoYLj7Vkj+0WaRl2et4zY3FCwfEndZP5P2A+P7KJ9QQzuNcqQkNeFhJG444en LUpRqPEk0msjDBsj4r7uErGDFyznn+x56hQ5RGhSjsG2zgZ53sYSnhyNPhgiM2JOri/n barfjxmMCOewXPvnHHKrF5aR+MroVgskdz4r9nck703HQ1EkW0qEFO57CnDurXPiz07j AvzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YdmBi9RCPi2M/mRVqHoLZJEZLt0wcJEBSae7OLzaLcY=; b=QRNPK0RZDoBWiv+q4Hvexcsxe5y3NbAv3kkkpD5i7Vpg64PWGLxCvi6Mg8MeTFH1hz ij9p3jyh0oaLGq9BchMqsPFeFYVykc3Rlhj7owRrs6QKFr45XnCbhEIPGRwBhdwZt5V+ OsL+eGi/07YDWr5N3K+h0vdUDEwXE+3IdVjjNEH5ggEEeUxJ5rLz39w3OXKQFFrqOCS7 /0HXn7f1Es9/9e6TggAVT+xilKH20tJTA955dLlC7jHauX4hS7Jnps565+tlpSR3kjTo 7uUBVQxSleUncq1RoQErMFEMlQ91VOJut+emsLLBcRJlTU9QrNOKSeFhkZD1C5s+3Kl3 k1kg== X-Gm-Message-State: AFqh2krPxLnr1qgg9/r1gvlDGM2j+fLtXmA8+jMHbm1bgBp6gJFvYGIz 6OyOKXD1sGq3Q7YDEGTqEdc= X-Google-Smtp-Source: AMrXdXuMLp2q+dbutwRS9YRMDNWsobDjgQeg568qJ8qWu0OmCZIPiqa8wMLLXU0s931pvEoj3/bUwg== X-Received: by 2002:aa7:8f11:0:b0:58e:2112:bc2d with SMTP id x17-20020aa78f11000000b0058e2112bc2dmr2001374pfr.6.1674241323558; Fri, 20 Jan 2023 11:02:03 -0800 (PST) Received: from nathanxps13 ([50.47.162.83]) by smtp.gmail.com with ESMTPSA id e8-20020aa79808000000b005897f5436c0sm21419534pfl.118.2023.01.20.11.02.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Jan 2023 11:02:02 -0800 (PST) Date: Fri, 20 Jan 2023 11:02:01 -0800 From: Nathan Bossart To: Andres Freund Cc: Tom Lane , Xing Guo , pgsql-hackers@postgresql.org Subject: Re: PL/Python: Fix return in the middle of PG_TRY() block. Message-ID: <20230120190201.GC4106863@nathanxps13> References: <20230112184433.GA2104952@nathanxps13> <20230113054900.b7onkvwtkrykeu3z@awork3.anarazel.de> <20230113180335.GA2160040@nathanxps13> <1864041.1673882943@sss.pgh.pa.us> <20230120010711.jpqbaelpgmuvt2vq@awork3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230120010711.jpqbaelpgmuvt2vq@awork3.anarazel.de> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Jan 19, 2023 at 05:07:11PM -0800, Andres Freund wrote: > I'm somewhat dubious about allowing to return inside PG_CATCH, even if it's > safe today. +1. Unless there are known use-cases, IMHO it'd be better to restrict it to prevent future compatibility breaks as PG_TRY evolves. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com