Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pK17I-00023h-VF for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jan 2023 18:00:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pK17H-0003ai-8X for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Jan 2023 18:00:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pK17G-0003aY-Qw for pgsql-hackers@lists.postgresql.org; Mon, 23 Jan 2023 18:00:22 +0000 Received: from mail-il1-x133.google.com ([2607:f8b0:4864:20::133]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pK17D-0003N9-6H for pgsql-hackers@lists.postgresql.org; Mon, 23 Jan 2023 18:00:21 +0000 Received: by mail-il1-x133.google.com with SMTP id b15so4148234ils.11 for ; Mon, 23 Jan 2023 10:00:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20210112.gappssmtp.com; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=i37Y0oZ7XX4pAVHDup1tGFFWlwEjtLDvikAXpOonKhU=; b=COl38KQrbAU880O4E51WBtCFPbga6r9/mKi890vdER/fHe02ARwpWj/lYIFcWgk0d1 JG78tfVfWIXcB4wbnJTK2lb7CUPv5ao8X8BNhIK3AfwEtC5zNWkN57BSTG6ElGheWpQp wHQQUn/Esooi8nMdTg5yuuIGq5YGMuw3cRLiR0fLoLZBimJsimlpUyZKibLNGd2O/JJB Tjqao10JY6IRIVZqAmbr2hBAop7Jbtk6ZGAjvgQuN+Ep8JLyNFZMmZn9XJrw59w94EBu n9NjkEhGnDRILZAwORJaCDRagzMcsFMfFXWJBzAYSeLx+tsWxqY1rCboZT7FJgkpTYHl jarw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i37Y0oZ7XX4pAVHDup1tGFFWlwEjtLDvikAXpOonKhU=; b=HOV/MwQn3K470nQDBrtjB24aO+If/fRFisXGHU8O1gE9X5dp8twcTUlVhwGDyHHTVH eIWkqjC2mrocsuZUTON5GAd5+y7oD+c5RexAPUGxZd+tMRud8ldOwkteZspMROVc2WIO j2EAgVOmf09h838niY5PTmwpFswYYbc3PNaUhkQ1gPMZ4l8YtklbtGTf8orFAEYJjCfq gBqcJZ75cBTjomnuGuUwn93LVZU4cvhxdS6rkBfBMubrwEGiVHlzaBaJTfuuR4XIM8q5 0ctg/iDKTF79ZPC8U+1/Z+QbE429mfF/8FjObU2r+IYppuv0DNaHs429rA/GRjQ9YO2N kccQ== X-Gm-Message-State: AFqh2kouPUXiJSlvUKjb6Gi3ND4t166/XV70tK+o/g6g7W1OHtqMSR5S LiVnxz+3ju18cTrVuJE4prlloA== X-Google-Smtp-Source: AMrXdXtGKvSjvYkvybkZ6vvaVmwuAdDoF+YODAcHnuPj84bPxJ9F+jxH5ua4kTPIl9QLaTQDYL/2lQ== X-Received: by 2002:a05:6e02:1d19:b0:30f:5a03:551e with SMTP id i25-20020a056e021d1900b0030f5a03551emr11191812ila.22.1674496817148; Mon, 23 Jan 2023 10:00:17 -0800 (PST) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id 191-20020a021dc8000000b0039e07ca9ae5sm14980632jaj.113.2023.01.23.10.00.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jan 2023 10:00:16 -0800 (PST) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id B304A800983; Mon, 23 Jan 2023 12:00:14 -0600 (CST) Date: Mon, 23 Jan 2023 12:00:14 -0600 From: Justin Pryzby To: gkokolatos@pm.me Cc: Tomas Vondra , Michael Paquier , pgsql-hackers@lists.postgresql.org, Rachel Heaton Subject: Re: Add LZ4 compression in pg_dump Message-ID: <20230123180014.GX13860@telsasoft.com> References: <41036470-041b-08a3-469d-fe07de2bc58e@enterprisedb.com> <6ab89d42-0345-b96e-02d4-68e171cdbe03@enterprisedb.com> <7zu6GYFi72jByVk2SEe_nd8r1DHhwA35vSntAE9sAfiMX9Lfk6bwimkwmu7GDgYaEvL27SE4qF1uK4_LHWQM4H-SXOwkMAI-GV8PKGmED_E=@pm.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Jan 23, 2023 at 05:31:55PM +0000, gkokolatos@pm.me wrote: > Please find attached v23 which reintroduces the split. > > 0001 is reworked to have a reduced footprint than before. Also in an attempt > to facilitate the readability, 0002 splits the API's and the uncompressed > implementation in separate files. Thanks for updating the patch. Could you address the review comments I sent here ? https://www.postgresql.org/message-id/20230108194524.GA27637%40telsasoft.com Thanks, -- Justin