Date: Tue, 24 Jan 2023 09:47:47 +0900 (JST)
Message-Id: <20230124.094747.1325518642290848983.horikyota.ntt@gmail.com>
To: tgl@sss.pgh.pa.us
Cc: sirichamarthi22@gmail.com, bharath.rupireddyforpostgres@gmail.com,
 pgsql-hackers@lists.postgresql.org
Subject: Re: Fix GetWALAvailability function code comments for
 WALAVAIL_REMOVED return value
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: <291749.1674171832@sss.pgh.pa.us>
References: <20221020.115946.1240575541659272220.horikyota.ntt@gmail.com>
	<CAKrAKeWNYVS8aatr94ohKKwA10-dWsBbK=qYZKZnFhRxpWfi7A@mail.gmail.com>
	<291749.1674171832@sss.pgh.pa.us>
User-Agent: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/20230124.094747.1325518642290848983.horikyota.ntt%40gmail.com>
Precedence: bulk

At Thu, 19 Jan 2023 18:43:52 -0500, Tom Lane <tgl@sss.pgh.pa.us> wrote in 
> sirisha chamarthi <sirichamarthi22@gmail.com> writes:
> > On Wed, Oct 19, 2022 at 7:59 PM Kyotaro Horiguchi <horikyota.ntt@gmail.com>
> > wrote:
> >> In short, the proposed fix alone seems fine to me. If we want to show
> >> further details, I would add a bit as follows.
> >> 
> >> | * * WALAVAIL_REMOVED means it has been removed. A replication stream on
> >> | *   a slot with this LSN cannot continue.  Note that the affected
> >> | *   processes have been terminated by checkpointer, too.
> 
> > Thanks for your comments! Attached the patch with your suggestions.
> 
> Pushed with a bit of additional wordsmithing.  I thought "have been"

Thanks!

> was a bit too strong of an assertion considering that this function
> does not pay any attention to the actual state of any processes,
> so I made it say "should have been".

I think you're correct here.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center