Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pK9cy-00052m-K4 for pgsql-hackers@arkaria.postgresql.org; Tue, 24 Jan 2023 03:05:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pK9cx-0006zy-Gz for pgsql-hackers@arkaria.postgresql.org; Tue, 24 Jan 2023 03:05:39 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pK9cx-0006y6-69 for pgsql-hackers@lists.postgresql.org; Tue, 24 Jan 2023 03:05:39 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pK9ct-0000wh-Su for pgsql-hackers@postgresql.org; Tue, 24 Jan 2023 03:05:37 +0000 Received: by mail-pl1-x634.google.com with SMTP id a18so889713plm.2 for ; Mon, 23 Jan 2023 19:05:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:from:subject:cc:to:message-id:date:from:to:cc:subject :date:message-id:reply-to; bh=8E+dOEuohGG0NSRcmSpEmtvQ0uYVE09SnsOfNu19Zik=; b=B1WjpsG6r00VESLd+4YBPylhp+FTzQTi39Tw1dY7+Ty3mDazvdCkufhvBnRiuHrEPw J6Wc3SJNb/Ps84aaU/K6Oq7NU4ixLM3IC45yc8JeI69wlTXA1oteRH4VUy8GkITy2ihn eoS6wzYCqtBgcBeqg31WyC4ZglP1NVBEoI1BdymUqD0hhXyDPTmFF5iCeGtbmA1n9N+L Qu06BW1b3eKoJ++eZDnH8k8Lp0PrLLmkr8DYAxwhVMEri3gc1V8L23FQzBypARIppnLA R2WLkqJrJ20KAUTYLycIC5+zKBqC97xBHQ2ZpW0CDKKJ99dcaoU6oe9n1BQyx+FZVPhx jkIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:from:subject:cc:to:message-id:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8E+dOEuohGG0NSRcmSpEmtvQ0uYVE09SnsOfNu19Zik=; b=Zn3e5FV+eXRHUwSmNlRBm8444vaY5almEB/0wtPpGG8/kN8KRCgodxlhGL0ngjV/TU M9cUxZ8Ig5BsUl9+6lPyVCt9hvdeJqcLXrHRDtuT9Eds0QS6MGn+w9qDaHfair/MKPYq lB41Pr7i9DKVAIL3U7fkTNIWt3d3MRe0qJMdCZ/gukk7GlJU09oVl7fLuOZS8Ep6l2tr 6g9rmcPrK9HouTx+e5EesPhcakAwXDB6CmVUsXTvQztJyTKxKC+5goT16wsc9ZGJ9CLZ RsghSW05XVbxfBF836PBkL4oEc/vVrBSuM/ZD9G0ZWmE79QGavzbGPW3kpW4OhE4yIVd zPJg== X-Gm-Message-State: AFqh2kqcPUqrhCfqLx72d/a093j+dRBVliLOfuirUkH46X71ihnEtyes X1l1HxwXtkPfRaSf3HCd5Kc= X-Google-Smtp-Source: AMrXdXuB8GjIoVO7C3Wyh/uEqzOBBExjxHONmGpkHzh8Nd2qUTC4OZn5MDP7wYgn2qq6oG42nW9zGA== X-Received: by 2002:a17:90b:1209:b0:229:14da:12c8 with SMTP id gl9-20020a17090b120900b0022914da12c8mr27360807pjb.46.1674529534756; Mon, 23 Jan 2023 19:05:34 -0800 (PST) Received: from localhost (KD036014041111.ppp-bb.dion.ne.jp. [36.14.41.111]) by smtp.gmail.com with ESMTPSA id p9-20020a17090a284900b0022b787fb08dsm7294665pjf.5.2023.01.23.19.05.31 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 23 Jan 2023 19:05:34 -0800 (PST) Date: Tue, 24 Jan 2023 12:05:30 +0900 (JST) Message-Id: <20230124.120530.2135381706312774067.horikyota.ntt@gmail.com> To: osumi.takamichi@fujitsu.com Cc: smithpb2250@gmail.com, vignesh21@gmail.com, kuroda.hayato@fujitsu.com, shveta.malik@gmail.com, dilipbalaut@gmail.com, amit.kapila16@gmail.com, euler@eulerto.com, m.melihmutlu@gmail.com, andres@anarazel.de, marcos@f10.com.br, pgsql-hackers@postgresql.org Subject: Re: Time delayed LR (WAS Re: logical replication restrictions) From: Kyotaro Horiguchi In-Reply-To: <20230124.114535.1107425862791533999.horikyota.ntt@gmail.com> References: <20230124.114535.1107425862791533999.horikyota.ntt@gmail.com> User-Agent: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Sorry, I forgot to write one comment. At Tue, 24 Jan 2023 11:45:35 +0900 (JST), Kyotaro Horiguchi wrote in + /* Should we delay the current transaction? */ + if (finish_ts) + maybe_delay_apply(xid, finish_ts); + if (!am_parallel_apply_worker()) maybe_start_skipping_changes(lsn); It may not give actual advantages, but isn't it better that delay happens after skipping? regards. -- Kyotaro Horiguchi NTT Open Source Software Center