Feedback-ID: id4a34324:Fastmail
Date: Mon, 23 Jan 2023 17:33:35 -0800
From: Andres Freund <andres@anarazel.de>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Michael Paquier <michael@paquier.xyz>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>, thomas.munro@gmail.com,
	tgl@sss.pgh.pa.us, john.naylor@enterprisedb.com,
	noriyoshi.shinoda@hpe.com, jchampion@timescale.com,
	sawada.mshk@gmail.com, masao.fujii@oss.nttdata.com,
	pgsql-hackers@postgresql.org, rjuju123@gmail.com
Subject: Re: Improve logging when using Huge Pages
Message-ID: <20230124013335.7u75j75ze5o7uh2l@awork3.anarazel.de>
References: <20221107151458.6puzamerxti2y5in@awork3.anarazel.de>
 <3239882.1667836576@sss.pgh.pa.us>
 <CA+hUKGKRfzOH9gji-W7j=iKDQ50AjtGSsUfybNxeNVk+uy2gcg@mail.gmail.com>
 <20221109.114757.661491395677294771.horikyota.ntt@gmail.com>
 <Y2s0wCFgDv4LXzIW@paquier.xyz>
 <20230124012100.GB13860@telsasoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230124012100.GB13860@telsasoft.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20230124013335.7u75j75ze5o7uh2l%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2023-01-23 19:21:00 -0600, Justin Pryzby wrote:
> Michael seemed to support this idea and nobody verbalized hatred of it,
> so I implemented it.  In v15, we have shared_memory_size_in_huge_pages,
> so this adds effective_huge_pages.
> 
> Feel free to suggest a better name.

Hm. Should this be a GUC? There's a reason shared_memory_size_in_huge_pages is
one - it's so it's accessible via -C. But here we could make it a function or
whatnot as well.

I'm ok with this being a GUC, it doesn't feel elegant, but I suspect there's
no realistic elegant answer.

Greetings,

Andres Freund