Feedback-ID: id4a34324:Fastmail
Date: Mon, 23 Jan 2023 19:28:06 -0800
From: Andres Freund <andres@anarazel.de>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers@postgresql.org, Robert Haas <robertmhaas@gmail.com>,
	Peter Geoghegan <pg@bowt.ie>, Tom Lane <tgl@sss.pgh.pa.us>,
	Fujii Masao <fujii@postgresql.org>,
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Subject: Re: postgres_fdw uninterruptible during connection establishment /
 ProcSignalBarrier
Message-ID: <20230124032806.qwz6xja4c5cshm3j@awork3.anarazel.de>
References: <20220925232237.p6uskba2dw6fnwj2@awork3.anarazel.de>
 <20221209020815.wsoixct72c6hst5l@awork3.anarazel.de>
 <20221229172330.jpuoljhtvivci3cd@awork3.anarazel.de>
 <CA+hUKGKumpwy+_Zx9_dshccF2HYKqwMCbeeSoOFXy+9ntsh54Q@mail.gmail.com>
 <20221229215437.s4q5lu6ijb67jugx@awork3.anarazel.de>
 <CA+hUKG+pZkPAag-KqSCDKcuUv03yBtKk0p-i662VbHi_Jzuyhw@mail.gmail.com>
 <20230103200520.di5hjebqvi72coql@awork3.anarazel.de>
 <20230110020501.bujiesmhe2fuka42@awork3.anarazel.de>
 <CA+hUKGLTngoe7NAWAOUut2p9uiWCKhvLfbaFJJi4p+QXeEZQ7A@mail.gmail.com>
 <20230121030008.acoon7nk7gnuslx4@awork3.anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230121030008.acoon7nk7gnuslx4@awork3.anarazel.de>
Archived-At: <https://www.postgresql.org/message-id/20230124032806.qwz6xja4c5cshm3j%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2023-01-20 19:00:08 -0800, Andres Freund wrote:
> Updated patch attached. I split it into multiple pieces.
> 1) A fix for [1], included here because I encountered it while testing
> 2) Introduction of libpq-be-fe-helpers.h
> 3) Convert dblink and postgres_fdw to the helper
> 4) Convert libpqwalreceiver.c to the helper
> 
> Even if we eventually decide to backpatch 3), we'd likely not backpatch 4), as
> there's no bug (although perhaps the lack of FD handling could be called a
> bug?).
> 
> There's also some light polishing, improving commit message, comments and
> moving some internal helper functions to later in the file.

After a tiny bit further polishing, and after separately pushing a resource
leak fix for walrcv_connect(), I pushed this.

Greetings,

Andres Freund