Feedback-ID: ia2694551:Fastmail
Date: Tue, 24 Jan 2023 19:27:28 +0100
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Helper functions for wait_for_catchup() in Cluster.pm
Message-ID: <20230124182728.bp6cyo74c77hb4vn@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2198c60b-9a6c-79a5-bb35-81f1ac3113bd@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/20230124182728.bp6cyo74c77hb4vn%40alvherre.pgsql>
Precedence: bulk

Looking again, I have two thoughts for making things easier:

1. I don't think wait_for_write_catchup is necessary, because
calling wait_for_catchup() and omitting the 'mode' and 'lsn' arguments
would already do the same thing.  So what we should do is patch places
that currently give those two arguments, so that they don't.

2. Because wait_for_replay_catchup is an instance method, passing the
second node as argument is needlessly noisy, because that's already
known as $self.  So we can just say

  $primary_node->wait_for_replay_catchup($standby_node);

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/