Date: Wed, 25 Jan 2023 09:57:29 -0800
From: Nathan Bossart <nathandbossart@gmail.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: tgl@sss.pgh.pa.us, houzj.fnst@fujitsu.com, amit.kapila16@gmail.com,
	m.melihmutlu@gmail.com, thomas.munro@gmail.com,
	kuroda.hayato@fujitsu.com, pgsql-hackers@postgresql.org
Subject: Re: wake up logical workers after ALTER SUBSCRIPTION
Message-ID: <20230125175729.GA1098626@nathanxps13>
References: <20230124171329.GA677220@nathanxps13>
 <2268133.1674584035@sss.pgh.pa.us>
 <20230124184217.GA724858@nathanxps13>
 <20230125.161200.735003108705492225.horikyota.ntt@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230125.161200.735003108705492225.horikyota.ntt@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20230125175729.GA1098626%40nathanxps13>
Precedence: bulk

On Wed, Jan 25, 2023 at 04:12:00PM +0900, Kyotaro Horiguchi wrote:
> At Tue, 24 Jan 2023 10:42:17 -0800, Nathan Bossart <nathandbossart@gmail.com> wrote in 
>> Here is a first attempt at a patch.  I scanned through all the existing
>> uses of InvalidDsaPointer and DSM_HANDLE_INVALID and didn't notice anything
>> else that needed adjusting.
> 
> There seems to be two cases for DSA_HANDLE_INVALID in dsa_get_handle
> and dsa_attach_in_place, one of which is Assert(), though.

Ah, sorry, I'm not sure how I missed this.  Thanks for looking.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com