Date: Thu, 26 Jan 2023 12:36:38 -0600
From: "Karl O. Pinc" <kop@karlpinc.com>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Devrim =?UTF-8?B?R8O8bmTDvHo=?= <devrim@gunduz.org>, Joe Conway
 <mail@joeconway.com>, Robert Haas <robertmhaas@gmail.com>, Andres Freund
 <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers
 <pgsql-hackers@postgresql.org>
Subject: Re: drop postmaster symlink
Message-ID: <20230126123638.1e918fef@slate.karlpinc.com>
In-Reply-To: <20230125180325.696f2cd7@slate.karlpinc.com>
References: <ece84b69-8f94-8b88-925f-64207cb3a2f0@enterprisedb.com>
	<252b8b14-dc3e-1c70-3da5-e59c1616f2ad@joeconway.com>
	<6b11c9efcd3a1d89719370224d84f8cd5e7b1a8c.camel@gunduz.org>
	<3705500.1669216069@sss.pgh.pa.us>
	<20221123195010.huuypoilx6lw7ceg@awork3.anarazel.de>
	<CA+TgmoZdJ3TOBCnoz0x0zzfOtbOR12f1PHLQP8G1U3NEycUgRw@mail.gmail.com>
	<61846051-90b9-adb6-7627-08a374473a61@joeconway.com>
	<63a898b5-dc09-1ec1-40ec-e9d09e8304e7@enterprisedb.com>
	<b46cb741-7856-2410-0c4f-2af9e0fb9892@joeconway.com>
	<05cd2e78dd3b7142f16fd7f14b1694c3520af345.camel@gunduz.org>
	<7165e051-94c7-4e14-ff0a-043b34c67e9e@enterprisedb.com>
	<f6c7bdd1102e9f8b1013a2d4a4552759a695b900.camel@gunduz.org>
	<20230125180325.696f2cd7@slate.karlpinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20230126123638.1e918fef%40slate.karlpinc.com>
Precedence: bulk

On Wed, 25 Jan 2023 18:03:25 -0600
"Karl O. Pinc" <kop@k

> Buried in
> https://www.postgresql.org/message-id/20230107165942.748ccf4e%40slate.karlpinc.com
> is the one change I see that should be made.
> 
> > In doc/src/sgml/ref/allfiles.sgml at line 222 there is an ENTITY
> > defined which references the deleted postmaster.sgml file.  
> 
> This line needs to be removed and the
> 0002-Don-t-install-postmaster-symlink-anymore.patch 
> updated.  (Unless there's some magic going on
> with the various allfiles.sgml files of which I am
> not aware.)
> 
> If this is fixed I see no other problems.

Buried in the same email, and I apologize for not mentioning
this, is one other bit of documentation text that might
or might not need attention. 

> I see a possible problem at line 1,412 of runtime.sgml

This says:

 in the postmaster's startup script just before invoking the postmaster.

Depending on how this is read, it could be interpreted to mean
that a "postmaster" binary is invoked.  It might be more clear
to write: ... just before invoking <command>postgres</command>.

Or it might not be worth bothering about; at this point, probably
not, but I thought you might want the heads-up anyway.

Regards,

Karl <kop@karlpinc.com>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein