Date: Fri, 27 Jan 2023 20:17:46 -0800
From: Nathan Bossart <nathandbossart@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>, pgsql-hackers@postgresql.org
Subject: Re: recovery modules
Message-ID: <20230128041746.GA2288302@nathanxps13>
References: <Y8Yy01LBF12k9755@paquier.xyz>
 <20230117182356.GA3015764@nathanxps13>
 <Y8dZgIeqsLe6NP6B@paquier.xyz>
 <20230118044427.GA3369836@nathanxps13>
 <Y830qTRZJP6XGuOF@paquier.xyz>
 <20230123214428.GA572995@nathanxps13>
 <Y9Dbfe3C0wGJqyav@paquier.xyz>
 <20230128002319.362oxrxf7ardfz2a@awork3.anarazel.de>
 <20230128005910.GA2245287@nathanxps13>
 <20230128015542.baefifnqgpgtkij6@awork3.anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230128015542.baefifnqgpgtkij6@awork3.anarazel.de>
Archived-At: 
 <https://www.postgresql.org/message-id/20230128041746.GA2288302%40nathanxps13>
Precedence: bulk

On Fri, Jan 27, 2023 at 05:55:42PM -0800, Andres Freund wrote:
> On 2023-01-27 16:59:10 -0800, Nathan Bossart wrote:
>> I think it would be weird for the archive module and
>> recovery module interfaces to look so different, but if that's okay, I can
>> change it.
> 
> I'm a bit sad about the archive module case - I wonder if we should change it
> now, there can't be many users of it out there. And I think it's more likely
> that we'll eventually want multiple archiving scripts to run concurrently -
> which will be quite hard with the current interface (no private state).

I'm open to that.  IIUC it wouldn't require too many changes to existing
archive modules, and if it gets us closer to batching or parallelism, it's
probably worth doing sooner than later.

> I was wondering why we implement "shell" via a separate mechanism from
> restore_library. I.e. a) why doesn't restore_library default to 'shell',
> instead of an empty string, b) why aren't restore_command et al implemented
> using a restore module.

I think that's the long-term idea.  For archive modules, there were
concerns about backward compatibility [0].

[0] https://postgr.es/m/CABUevEx8cKy%3D%2BYQU_3NaeXnZV2bSB7Lk6EE%2B-FEcmE4JO4V1hg%40mail.gmail.com

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com