Date: Sat, 4 Feb 2023 11:11:01 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, Noah Misch <noah@leadboat.com>,
	Andrew Dunstan <andrew@dunslane.net>,
	Jelte Fennema <postgres@jeltef.nl>, Peter Geoghegan <pg@bowt.ie>,
	Bruce Momjian <bruce@momjian.us>,
	Magnus Hagander <magnus@hagander.net>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	Stephen Frost <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>,
	pgsql-hackers@postgresql.org
Subject: Re: run pgindent on a regular basis / scripted manner
Message-ID: <20230204171101.GF1653@telsasoft.com>
References: 
 <CAH2-Wzm0niYBPcN6eX3PzHABfj0dE3fwifo5bdturvMp=9FGqw@mail.gmail.com>
 <20230122094957.x542ojaqgi4lalq4@awork3.anarazel.de>
 <CAGECzQRYjHdNQ-Bq2yrBb-8s3Pjx7pfvYPDdNv9tcvDcscDhbg@mail.gmail.com>
 <20230122223806.3sgew6qswhsczae7@awork3.anarazel.de>
 <1489276.1674427657@sss.pgh.pa.us>
 <de0a7034-0186-1f91-b408-eb67f2a854dc@dunslane.net>
 <1708030.1675446770@sss.pgh.pa.us>
 <20230204041848.GC1896331@rfd.leadboat.com>
 <20230204113453.vmtnayjvhyg5qqqy@alap3.anarazel.de>
 <1923921.1675526879@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1923921.1675526879@sss.pgh.pa.us>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20230204171101.GF1653%40telsasoft.com>
Precedence: bulk

On Sat, Feb 04, 2023 at 11:07:59AM -0500, Tom Lane wrote:
> (I haven't forgotten that I'm on the hook to import pg_bsd_indent
> into our tree.  Will get to that soon.)

+1 for that - it's no surprise that you have trouble convincing people
to follow the current process:

1) requires using a hacked copy of BSD indent; 2) which is stored
outside the main repo; 3) is run via a perl script that itself mungles
the source code (because the only indent tool that can support the
project's style doesn't actually support what's needed); 4) and wants to
retrieve a remote copy of typedefs.list (?). 

The only thing that makes this scheme even remotely viable is that
apt.postgresql.org includes a package for pg-bsd-indent.  I've used it
only a handful of times by running:
pg_bsd_indent -bad -bap -bbb -bc -bl -cli1 -cp33 -cdb -nce -d0 -di12 -nfc1 -i4 -l79 -lp -lpl -nip -npro -sac -tpg -ts4 -U .../typedefs.list

The perl wrapper is still a step too far for me (maybe it'd be tolerable
if available as a build target).

Would you want to make those the default options of the in-tree indent ?
Or provide a shortcut like --postgresql ?

-- 
Justin