Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pPUS1-0007gl-QF for pgsql-hackers@arkaria.postgresql.org; Tue, 07 Feb 2023 20:20:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pPUS0-00079M-LN for pgsql-hackers@arkaria.postgresql.org; Tue, 07 Feb 2023 20:20:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pPUS0-00079C-C1 for pgsql-hackers@lists.postgresql.org; Tue, 07 Feb 2023 20:20:24 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pPURx-00059X-IT for pgsql-hackers@postgresql.org; Tue, 07 Feb 2023 20:20:23 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8832B5C0193; Tue, 7 Feb 2023 15:20:20 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 07 Feb 2023 15:20:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1675801220; x= 1675887620; bh=9ULRKNf7PG0P0by7wuORjbl+PJOyszgeHOmeyv3zbsI=; b=q QubYUQB1NIViYZSIo62PNZuF6s/5rOHos9h1k7m6GcltI2YtVMJRGDbvIDNDh6Nh 6/7tKPZj//kyhvDYBhPaEx5+RiZvLqAw8zOCZlSSWEBb1PzubFbMTHsYR/rGREh1 PQmby4/JnvNeN6HuPKfnxwREF1QGx33pfG5RqGOmdtqWmmvzyMVs+vB+qZV1jmt+ jlyXHAvF5YgP5dUwS1EaG6MBfb8/Zi8FWcVwr9+CuRWvmS8RlxwOqg+ZEVTs1QMr TXfjqCycG1DdUZei+/W5Cym3+fb/dlc9ISAF8+8kZgjoYR8YbhcE7DIYquVw0DeN UGJoW+h0yM+gKxS9S6ylA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1675801220; x= 1675887620; bh=9ULRKNf7PG0P0by7wuORjbl+PJOyszgeHOmeyv3zbsI=; b=H AgSCJQJyF2dCcEOiGXW0JZgMyIOvA+zChakBHurO4tCa54NhLWgDldqxDebt7BCQ q8ai734Af0v0pS85pUjpXi+ya1eY9AbmJou09iUfkePSgMK4lfvqkBH4td7Vx+Rs iR/A/qe8EVP2xjR04kjJU6zBMAE54+AvFgeC4jEv35txQo6ELqS4kzm+CgzDCOJL Ho4r3ecSGc9ZnH7pKKOXbgf3kG6JKRM5hSyXNFEuU6CSKqXLaM7PFmOzQQ2tjalf SGVpu8FVFjr6fV+9bfXWy7ohBlsaBnm3qDaPKJVDR5aM00leU7IMRWb/0Hv4/+OQ dN94zj8QM5jeijtQ1cVWA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegkedgudefvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtugfgjgesthekredttddtjeenucfhrhhomheptehn ughrvghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecugg ftrfgrthhtvghrnhepueelieeuhfdtiedtkeehkeeiuedtheekjeelleekhfekheeutedt tedufeeftddvnecuffhomhgrihhnpegtihhrrhhushdqtghirdgtohhmnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghnughrvghssegrnhgr rhgriigvlhdruggv X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 7 Feb 2023 15:20:19 -0500 (EST) Date: Tue, 7 Feb 2023 12:20:19 -0800 From: Andres Freund To: "Bagga, Rishu" Cc: pgsql-hackers , Heikki Linnakangas , Thomas Munro , "Debnath, Shawn" , vignesh C Subject: Re: SLRUs in the main buffer pool - Page Header definitions Message-ID: <20230207202019.mhovw7aopjy3bile@awork3.anarazel.de> References: <7C4D53F1-A156-4ABC-9B89-B2C253D5FF74@amazon.com> <7BAF384A-654C-4877-BB4D-EDE4E44A9326@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7BAF384A-654C-4877-BB4D-EDE4E44A9326@amazon.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2023-02-06 19:12:47 +0000, Bagga, Rishu wrote: > Rebased patch as per latest community changes since last email. This version doesn't actually build. https://cirrus-ci.com/task/4512310190931968 [19:43:20.131] FAILED: src/test/modules/test_slru/test_slru.so.p/test_slru.c.o [19:43:20.131] ccache cc -Isrc/test/modules/test_slru/test_slru.so.p -Isrc/include -I../src/include -Isrc/include/catalog -Isrc/include/nodes -Isrc/include/utils -Isrc/include/storage -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -g -fno-strict-aliasing -fwrapv -fexcess-precision=standard -D_GNU_SOURCE -Wmissing-prototypes -Wpointer-arith -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -Wdeclaration-after-statement -Wno-format-truncation -Wno-stringop-truncation -fPIC -pthread -fvisibility=hidden -MD -MQ src/test/modules/test_slru/test_slru.so.p/test_slru.c.o -MF src/test/modules/test_slru/test_slru.so.p/test_slru.c.o.d -o src/test/modules/test_slru/test_slru.so.p/test_slru.c.o -c ../src/test/modules/test_slru/test_slru.c [19:43:20.131] ../src/test/modules/test_slru/test_slru.c:47:8: error: unknown type name ‘SlruCtlData’ [19:43:20.131] 47 | static SlruCtlData TestSlruCtlData; [19:43:20.131] | ^~~~~~~~~~~ [19:43:20.131] ../src/test/modules/test_slru/test_slru.c:57:19: error: unknown type name ‘SlruCtl’ [19:43:20.131] 57 | test_slru_scan_cb(SlruCtl ctl, char *filename, int segpage, void *data) [19:43:20.131] | ^~~~~~~ ... Andres