Feedback-ID: id4a34324:Fastmail
Date: Tue, 7 Feb 2023 12:28:34 -0800
From: Andres Freund <andres@anarazel.de>
To: "wangw.fnst@fujitsu.com" <wangw.fnst@fujitsu.com>
Cc: vignesh C <vignesh21@gmail.com>, Peter Smith <smithpb2250@gmail.com>,
	"Takamichi Osumi (Fujitsu)" <osumi.takamichi@fujitsu.com>,
	Amit Kapila <amit.kapila16@gmail.com>,
	"shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>,
	"houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>,
	Amit Langote <amitlangote09@gmail.com>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
	Dilip Kumar <dilipbalaut@gmail.com>,
	Greg Nancarrow <gregn4422@gmail.com>
Subject: Re: Data is copied twice when specifying both child and parent table
 in publication
Message-ID: <20230207202834.c2ptvco7dv57t3hi@awork3.anarazel.de>
References: <OS3PR01MB62751414E4DABF144F5E481C9E529@OS3PR01MB6275.jpnprd01.prod.outlook.com>
 <CAHut+PtTN1Udug3x1eZnDdh8Z6PL5VN=xz1b44VbB9T1z_PtcQ@mail.gmail.com>
 <OS3PR01MB6275A9B8C65C381C6828DF9D9E549@OS3PR01MB6275.jpnprd01.prod.outlook.com>
 <CAHut+PvaSDuZ7PhzZOm4c2u-sbN4DUsZr22qyYQ8dncUpqMpXg@mail.gmail.com>
 <OS3PR01MB6275843B2BBE92870F7881C19E299@OS3PR01MB6275.jpnprd01.prod.outlook.com>
 <CAHut+Pt+1PNx6VsZ-xKzAU-18HmNXhjCC1TGakKX46Wg7YNT1Q@mail.gmail.com>
 <OS3PR01MB6275FB5397C6A647F262A3A69E009@OS3PR01MB6275.jpnprd01.prod.outlook.com>
 <CALDaNm3ZzNJ6Y1iX=PBYCcCU+EPm4=9LVXFin5gvQ9XkEzc8UQ@mail.gmail.com>
 <OS3PR01MB6275C62FF1D1CDE4FCBF61339E079@OS3PR01MB6275.jpnprd01.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <OS3PR01MB6275C62FF1D1CDE4FCBF61339E079@OS3PR01MB6275.jpnprd01.prod.outlook.com>
Archived-At: <https://www.postgresql.org/message-id/20230207202834.c2ptvco7dv57t3hi%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2022-11-16 08:58:31 +0000, wangw.fnst@fujitsu.com wrote:
> Attach the new patch set.

This patch causes several of the tests to fail. See e.g.:

https://cirrus-ci.com/task/6587624765259776

Most of the failures appear to be due to the main regression tests failing:
https://api.cirrus-ci.com/v1/artifact/task/6587624765259776/testrun/build/testrun/regress/regress/regression.diffs

diff -U3 /tmp/cirrus-ci-build/src/test/regress/expected/publication.out /tmp/cirrus-ci-build/build/testrun/regress/regress/results/publication.out
--- /tmp/cirrus-ci-build/src/test/regress/expected/publication.out	2023-02-07 20:19:34.318018729 +0000
+++ /tmp/cirrus-ci-build/build/testrun/regress/regress/results/publication.out	2023-02-07 20:22:53.545223026 +0000
@@ -1657,7 +1657,7 @@
 SELECT * FROM pg_publication_tables;
  pubname | schemaname | tablename  | attnames | rowfilter 
 ---------+------------+------------+----------+-----------
- pub     | sch2       | tbl1_part1 | {a}      | 
+ pub     | sch2       | tbl1_part1 |          | 
 (1 row)
 
 DROP PUBLICATION pub;