Date: Wed, 8 Feb 2023 09:27:05 -0800
From: Nathan Bossart <nathandbossart@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>, pgsql-hackers@postgresql.org
Subject: Re: recovery modules
Message-ID: <20230208172705.GA451849@nathanxps13>
References: <20230201115426.6japkd3rfs36hbhk@alap3.anarazel.de>
 <20230201201529.GA3551058@nathanxps13>
 <20230201210606.nvfbuvzfby3gskvu@alap3.anarazel.de>
 <20230201212326.GA3593344@nathanxps13>
 <Y9tLWcninCsugVMP@paquier.xyz>
 <20230202193700.GA3887858@nathanxps13>
 <Y93KCKGQ2QGn1oDi@paquier.xyz>
 <20230204181436.GA267131@nathanxps13>
 <Y+NN9uZxFwkIN2d8@paquier.xyz>
 <20230208162713.zavyhxywheh4kuns@awork3.anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230208162713.zavyhxywheh4kuns@awork3.anarazel.de>
Archived-At: 
 <https://www.postgresql.org/message-id/20230208172705.GA451849%40nathanxps13>
Precedence: bulk

On Wed, Feb 08, 2023 at 08:27:13AM -0800, Andres Freund wrote:
> One minor thing: I don't think we really need the AssertVariableIsOfType() for
> anything but the Init() one?

This is another part that was borrowed from logical decoding output
plugins.  I'm not sure this adds much since f2b73c8 ("Add central
declarations for dlsym()ed symbols").  Perhaps we should remove all of
these assertions for functions that now have central declarations.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com