Date: Sun, 12 Feb 2023 14:59:36 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>,
	Jelte Fennema <postgres@jeltef.nl>, shiy.fnst@fujitsu.com,
	Robert Haas <robertmhaas@gmail.com>,
	Andres Freund <andres@anarazel.de>, Noah Misch <noah@leadboat.com>,
	Peter Geoghegan <pg@bowt.ie>, Bruce Momjian <bruce@momjian.us>,
	Magnus Hagander <magnus@hagander.net>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	Stephen Frost <sfrost@snowman.net>, Jesse Zhang <sbjesse@gmail.com>,
	pgsql-hackers@postgresql.org
Subject: Re: run pgindent on a regular basis / scripted manner
Message-ID: <20230212205936.GV1653@telsasoft.com>
References: 
 <CAGECzQRJrcoxozHh=BRTdLrirFui-3nvdRZru7GGa4F9HJV2Rw@mail.gmail.com>
 <b8f18576-afc0-d961-b33b-c0fa2e63edeb@dunslane.net>
 <0f074818-b01a-799f-3c74-5fb5deab1d23@dunslane.net>
 <CAGECzQSUYmfTwEWcVfwb4d=vf=M7RYJjq6ie0YPTUhP+YFcEww@mail.gmail.com>
 <1d66447e-a77b-ca0d-90a0-782800e85383@dunslane.net>
 <TYAPR01MB6315B86619944D4A6B56842DFDDE9@TYAPR01MB6315.jpnprd01.prod.outlook.com>
 <CAGECzQT44xN-zcTQ0+OxLpWa9nONxmEaYxQpaWM+My+A4o72PA@mail.gmail.com>
 <390e7b04-11f3-f715-7a7d-d1a9077fbea8@dunslane.net>
 <00885533-!ff96-2a95-7911-329c873b3029@dunslane.net>
 <842819.1676219054@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <842819.1676219054@sss.pgh.pa.us>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20230212205936.GV1653%40telsasoft.com>
Precedence: bulk

On Sun, Feb 12, 2023 at 11:24:14AM -0500, Tom Lane wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
> > ... then you could do
> >      pgindent `git dirty`
> > The only danger would be if there were no dirty files. Maybe we need a 
> > switch to inhibit using the current directory if there are no command 
> > line files.
> 
> It seems like "indent the whole tree" is about to become a minority
> use-case.  Maybe instead of continuing to privilege that case, we
> should say that it's invoked by some new switch like --all-files,
> and without that only the stuff identified by command-line arguments
> gets processed.

It seems like if pgindent knows about git, it ought to process only
tracked files.  Then, it wouldn't need to manually exclude generated
files, and it wouldn't process vpath builds and who-knows-what else it
finds in CWD.

At least --commit doesn't seem to work when run outside of the root
source dir.

-- 
Justin