Date: Thu, 16 Feb 2023 10:10:16 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Andres Freund <andres@anarazel.de>, Greg Stark <stark@mit.edu>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
	Zhihong Yu <zyu@yugabyte.com>, pgsql-hackers@lists.postgresql.org
Subject: Re: PATCH: Using BRIN indexes for sorted output
Message-ID: <20230216161016.GV1653@telsasoft.com>
References: <1607e037-8c5b-1626-9f98-496f067b9eb5@enterprisedb.com>
 <CAEze2WgN9LhrrZD3kTHw28sTty5Zc6AYMyFqROJ9wmKH0eF6yw@mail.gmail.com>
 <0695af03-8bd3-f032-47aa-0657135ce45d@enterprisedb.com>
 <CAEze2Wi7S7bMeUpMyBbnGLrFgcWQTDN1edSXYcd8WixeBj9B_w@mail.gmail.com>
 <87964cda-e440-8759-2838-bc4628072a18@enterprisedb.com>
 <CAM-w4HMirdJ-c4chCZhni_T=9R65z2Zm3Ajg5mBrQ9s6OufZXQ@mail.gmail.com>
 <14568731-ac91-ce2d-1477-0e2504c72775@enterprisedb.com>
 <20221206185143.ivy3afwmkhloksgv@awork3.anarazel.de>
 <4e679562-fd9a-33a3-ce71-cd7a27525f8e@enterprisedb.com>
 <e0b6e395-3ab7-6021-b058-3c5901912b36@enterprisedb.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e0b6e395-3ab7-6021-b058-3c5901912b36@enterprisedb.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20230216161016.GV1653%40telsasoft.com>
Precedence: bulk

On Thu, Feb 16, 2023 at 03:07:59PM +0100, Tomas Vondra wrote:
> Rebased version of the patches, fixing only minor conflicts.

Per cfbot, the patch fails on 32 bit builds.
+ERROR:  count mismatch: 0 != 1000

And causes warnings in mingw cross-compile.

On Sun, Oct 23, 2022 at 11:32:37PM -0500, Justin Pryzby wrote:
> I think new GUCs should be enabled during patch development.
> Maybe in a separate 0002 patch "for CI only not for commit".
> That way "make check" at least has a chance to hit that new code
> paths.
> 
> Also, note that indxpath.c had the var initialized to true.

In your patch, the amstats guc is still being set to false during
startup by the guc machinery.  And the tests crash everywhere if it's
set to on:

TRAP: failed Assert("(nmatches_unique >= 1) && (nmatches_unique <= unique[nvalues-1])"), File: "../src/backend/access/brin/brin_minmax.c", Line: 644, PID: 25519

>  . Some typos in your other patches: "heuristics heuristics".  ste.
>    lest (least).

These are still present.

-- 
Justin