Feedback-ID: ia2694551:Fastmail
Date: Thu, 16 Feb 2023 20:38:27 +0100
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: "Jonathan S. Katz" <jkatz@postgresql.org>
Cc: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>,
	Amit Kapila <amit.kapila16@gmail.com>,
	Ajin Cherian <itsajin@gmail.com>,
	Peter Smith <smithpb2250@gmail.com>,
	vignesh C <vignesh21@gmail.com>, Zheng Li <zhengli10@gmail.com>,
	li jie <ggysxcq@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>,
	Masahiko Sawada <sawada.mshk@gmail.com>,
	Japin Li <japinli@hotmail.com>,
	rajesh singarapu <rajesh.rs0541@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Support logical replication of DDLs
Message-ID: <20230216193827.h4p6dtjg244ox5fj@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <bac564be-a631-4ac4-0a47-be5977a29883@postgresql.org>
Archived-At: <https://www.postgresql.org/message-id/20230216193827.h4p6dtjg244ox5fj%40alvherre.pgsql>
Precedence: bulk

On 2023-Feb-16, Jonathan S. Katz wrote:

> On 2/16/23 12:53 PM, Alvaro Herrera wrote:

> > I don't think this is the fault of logical replication.  Consider that
> > for the backend server, the function source code is just an opaque
> > string that is given to the plpgsql engine to interpret.  So there's no
> > way for the logical DDL replication engine to turn this into runnable
> > code if the table name is not qualified.
> 
> Sure, that's fair. That said, the example above would fall under a "typical
> use case", i.e. I'm replicating functions that call tables without schema
> qualification. This is pretty common, and as logical replication becomes
> used for more types of workloads (e.g. high availability), we'll definitely
> see this.

Hmm, I think you're saying that replay should turn check_function_bodies
off, and I think I agree with that.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"El hombre nunca sabe de lo que es capaz hasta que lo intenta" (C. Dickens)