Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pULXK-0001pr-Hp for pgsql-hackers@arkaria.postgresql.org; Tue, 21 Feb 2023 05:49:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pULXI-000575-Ng for pgsql-hackers@arkaria.postgresql.org; Tue, 21 Feb 2023 05:49:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pULXI-00056w-Bg for pgsql-hackers@lists.postgresql.org; Tue, 21 Feb 2023 05:49:56 +0000 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pULXF-0004G3-Qu for pgsql-hackers@lists.postgresql.org; Tue, 21 Feb 2023 05:49:55 +0000 Received: by mail-pl1-x630.google.com with SMTP id q11so4148225plx.5 for ; Mon, 20 Feb 2023 21:49:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QC3PjfOYU9q/wPp03HSg3pitPOl7HyazsVm6T8bFMq0=; b=BKhvUbXoC+EuU/kYFrTcQFy9s84BrkdFna20f6fw3Vxv9f5IV0E42+IQ/exuGbgoiY c9kseapnIcS9t8KWBhgWDiYCEIAkPElyapdwlEOzRkAW5gGWsFuNsPVW1GdQe0mygnVX cBxbKPlp20J7X6SSNuQbUVNpDjLW93BDwGh1dML1i00Cn5VHH1WZJO9uMPY90ZpTuuI1 ZEd/a9Zddcjr/NgIsM0v6b3t2TmTKcFdVMBmEScwfzz/3KGTib2yo+d81LD2FGYxkk+I VF9+iEtPa9PujD/mBhIXJ5Pg4CU8dSoBZag7WmD7IozeMMQs1aG+1Jw7jb62Z9YjoiPf zeow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QC3PjfOYU9q/wPp03HSg3pitPOl7HyazsVm6T8bFMq0=; b=X8N1RzJsU5CBd3eNqJ4WB5LR84u3KptOzucNOMY/SNHGoy2qQLaHxkTxEBZAKorVlZ cK4gXgbN2I5psgGdvKyw7qXZMEtNejWAphAM8PBy4N9DQviBZbmqwtI+NRzKicv5kah5 I26+b//Q6am72zTuBcp6gFi0aibbm4qdkBNR0s1CSUrFogYc+e0El5VFLIMi8RlOp1F2 HGNG/WN6JsTrG/uKTIhhJuyfmhG22SCfGOEw7zOxarRr6XyjzX1qdreObLwklzTqRC8Y P67kcfsGaMAFze2ntJ4cfqmQPITPXdDwMpP0aEogApNmpOHaXCU8pifqWVpStXKa0PRF BTHg== X-Gm-Message-State: AO0yUKW64IHflmn6KrC2xwqUn2kKWQKJASLpfCMeTSI4NeaSc6jl8b1H MVKek7M3gfpuofEh9QKEZDg= X-Google-Smtp-Source: AK7set8k7/cfw+K/8mrUQsN2FSWjv5Pt9G5UZgcuZKsnKfLrVJMVHh5O6Wr493zZtseqbZxJKNGm8Q== X-Received: by 2002:a17:90b:33d1:b0:233:c03f:79d6 with SMTP id lk17-20020a17090b33d100b00233c03f79d6mr3099620pjb.44.1676958591292; Mon, 20 Feb 2023 21:49:51 -0800 (PST) Received: from nathanxps13 ([50.47.162.83]) by smtp.gmail.com with ESMTPSA id ie14-20020a17090b400e00b002372107fc3dsm348789pjb.49.2023.02.20.21.49.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 21:49:50 -0800 (PST) Date: Mon, 20 Feb 2023 21:49:48 -0800 From: Nathan Bossart To: Bharath Rupireddy Cc: Andres Freund , PostgreSQL Hackers Subject: Re: WAL Insertion Lock Improvements Message-ID: <20230221054948.GA2717@nathanxps13> References: <20221124184619.xit4sfi52bcz2tva@awork3.anarazel.de> <20221202004042.qwjadmkpq4zky3tn@awork3.anarazel.de> <20221203003158.GA2518778@nathanxps13> <20221205183007.s72oygp63s43dqyz@awork3.anarazel.de> <20230208220603.GA546776@nathanxps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, Feb 09, 2023 at 11:51:28AM +0530, Bharath Rupireddy wrote: > On Thu, Feb 9, 2023 at 3:36 AM Nathan Bossart wrote: >> Overall, I think this patch is in reasonable shape. > > Thanks for reviewing. Please see the attached v5 patch. I'm marking this as ready-for-committer. I think a couple of the comments could use some small adjustments, but that probably doesn't need to hold up this patch. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com