Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVSYJ-0001Su-5W for pgsql-hackers@arkaria.postgresql.org; Fri, 24 Feb 2023 07:31:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pVSYI-0003p2-1c for pgsql-hackers@arkaria.postgresql.org; Fri, 24 Feb 2023 07:31:34 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pVSYH-0003ot-MK for pgsql-hackers@lists.postgresql.org; Fri, 24 Feb 2023 07:31:33 +0000 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pVSYF-0007dv-K1 for pgsql-hackers@lists.postgresql.org; Fri, 24 Feb 2023 07:31:32 +0000 Received: by mail-pf1-x42f.google.com with SMTP id fd25so6570950pfb.1 for ; Thu, 23 Feb 2023 23:31:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:from:subject:to :message-id:date:from:to:cc:subject:date:message-id:reply-to; bh=f/pCFtE3ELYX8NyYR3Wk+GrKZYwJEpT2XCSPe8hskLU=; b=Eb+cmNcRakm+vPUEbR9CIyHlyOVj4BKLnyp1grCUOG5WVv4jBym0SHVKOXvOl75QZf oDPZ3f/Q2b5/wXcYflCmAd0oKI3MfVhFBcrh19qS0LD15t+c3Rm45mUaS5nwr63ALgQY +0+GzytKkxM862DCRiJZaymBBeuPZDFOZYXiHn8xBlTK4E9WlyfO2yx7HQKrqLL8JDtY /38fd2GYYsgpMbWFpaIO4kqhPhXN+u7IszeoTp3+5nVA/mlIHFp1n//VGmR5CHl1Q0H1 TFf7lVd3PjY/+pEeOReCJaAJ9CUI9BZewBT2+L6U+SDtH7yp+jeRkPZs67Tkuc7xb4j8 K+lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:from:subject:to :message-id:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f/pCFtE3ELYX8NyYR3Wk+GrKZYwJEpT2XCSPe8hskLU=; b=qCAkY09m0vzEbzeCsVK2Nm00RNx/ZvVmAUN7/OtLfa4fGYwlqEfMLLvJ5hqPICZRj+ iG3QUehHWv8Q9mbOmCXIZ2FGY7ZYiNTwhDF2KXHlaihPWtkN02O9lVMbRL9yv/sGVkv9 AwUdrYsSE/sH86Px6KRz7wXfwiNO6zs75jVMExbz6PIQX3ebncyPRiYTq0hEIYCRDTcZ /6Y714/Cg20O22FSZa3kGNZFzNxBcZO9Mt9TKAgAKZas0NC/kkYUJ4c1p5Pi27u8T86H cbe+agOtMFwYAuXoT7blDnDz4pI4UCq+yKqNtO2Frw3Yek/ippaS9+8mG6pw7dbW/WOd rR8A== X-Gm-Message-State: AO0yUKVSye5dO6lnKoIK2WKztXGf5RFozty+jy9V7BUP8xKLrZNG0y2U W7XJ9T21KaFDa5jkBcEnc7368jI/ATs= X-Google-Smtp-Source: AK7set8Sbiff7QZkTA2dOgsNR1fiLpe0fx1UxyLOkWRUiEyDIfuoQxmCa6TFeUHX2cVeL5r+G5p9WQ== X-Received: by 2002:a62:1a15:0:b0:5e5:6eea:5956 with SMTP id a21-20020a621a15000000b005e56eea5956mr203205pfa.3.1677223890212; Thu, 23 Feb 2023 23:31:30 -0800 (PST) Received: from localhost (KD036014041111.ppp-bb.dion.ne.jp. [36.14.41.111]) by smtp.gmail.com with ESMTPSA id j9-20020aa78009000000b005e099d7c30bsm1206649pfi.205.2023.02.23.23.31.28 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 23 Feb 2023 23:31:29 -0800 (PST) Date: Fri, 24 Feb 2023 16:31:27 +0900 (JST) Message-Id: <20230224.163127.68506240520261483.horikyota.ntt@gmail.com> To: pgsql-hackers@lists.postgresql.org Subject: New "blob" re-introduced? From: Kyotaro Horiguchi User-Agent: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk I noticed that the commit e9960732a9 introduced the following message. + if (EndCompressFileHandle(ctx->dataFH) != 0) + pg_fatal("could not close blob data file: %m"); It seems that we have removed the terminology "blob(s)" from user-facing messages by the commit 35ce24c333 (discussion is [1]). Shouldn't we use "large object" instead of "blob" in the message? [1] https://www.postgresql.org/message-id/868a381f-4650-9460-1726-1ffd39a270b4%40enterprisedb.com regards. -- Kyotaro Horiguchi NTT Open Source Software Center