Feedback-ID: ia2694551:Fastmail
Date: Wed, 1 Mar 2023 19:09:53 +0100
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: Nathan Bossart <nathandbossart@gmail.com>,
	vignesh C <vignesh21@gmail.com>, pgsql-hackers@postgresql.org
Subject: Re: add PROCESS_MAIN to VACUUM
Message-ID: <20230301180953.b64tekcnh43xtzqn@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <Y/7xVESfLgw3E/F/@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/20230301180953.b64tekcnh43xtzqn%40alvherre.pgsql>
Precedence: bulk

On 2023-Mar-01, Michael Paquier wrote:

> +-- PROCESS_MAIN option
> +VACUUM (PROCESS_MAIN FALSE) vactst;
> +VACUUM (PROCESS_MAIN FALSE, PROCESS_TOAST FALSE) vactst;
> +VACUUM (PROCESS_MAIN FALSE, FULL) vactst;
> 
> Thinking a bit here.  This set of tests does not make sure that the
> main relation and/or the toast relation have been actually processed. 
> pg_stat_user_tables does not track what's happening on the toast
> relations.  So...  What about adding some tests in 100_vacuumdb.pl
> that rely on vacuumdb --verbose and check the logs produced?  We
> should make sure that the toast or the main relation are processed,
> by tracking, for example, logs like vacuuming "schema.table".  When
> FULL is involved, we may want to track the changes on relfilenodes
> depending on what's wanted.

Maybe instead of reading the log, read values from pg_stat_all_tables.

-- 
Álvaro Herrera        Breisgau, Deutschland  —  https://www.EnterpriseDB.com/
"Uno puede defenderse de los ataques; contra los elogios se esta indefenso"