Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXVqL-0002I8-8y for pgsql-hackers@arkaria.postgresql.org; Wed, 01 Mar 2023 23:26:41 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pXVqJ-0005Vi-V1 for pgsql-hackers@arkaria.postgresql.org; Wed, 01 Mar 2023 23:26:39 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXVqJ-0005VY-J2 for pgsql-hackers@lists.postgresql.org; Wed, 01 Mar 2023 23:26:39 +0000 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pXVqH-0002FM-3s for pgsql-hackers@lists.postgresql.org; Wed, 01 Mar 2023 23:26:38 +0000 Received: by mail-pg1-x52a.google.com with SMTP id s18so8766748pgq.1 for ; Wed, 01 Mar 2023 15:26:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jVoZ1ZDMTkRm97AUJh58wVZy3yXCLJX3mIP61jS7yZE=; b=q25oimYIRB56SQPLJpXpTl+q8D2oRTH7oVS3vqoHB44zKMsBEOiqxdQZBdrNmc3mhh aqwpgBSApA7f5PJ3IQ/LzKcCyZR9pK5/MKFn9WctYnIeTsK+I1DdKdRTiFDNplxeAPLv hEKp6juoK1mwh5nL1nRj6PfrUNZDogNmhAzn6II1+6JPLD65VJ7nU+M5Rxt+x/76ii8t HvAQ59I9b8Lzv371fW66scrLl+OufPPMUlkw365znkTS/MHNDcKjF9ioXyHINXzav33M EsjtAj+Y5jdtksW6GZhxOl4dxJPN+II8Th+94WNNVAYhUSEYCj0BtvzzEC0uEDupHL7d ZqoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jVoZ1ZDMTkRm97AUJh58wVZy3yXCLJX3mIP61jS7yZE=; b=qnhopeffHYpZokfeE74/2NgcQigK0M0+HGNZOz5jcOI8MdyiznxuMNLnKELzrvReVD 5dgWxqZPpqnV+iQEvE5N8KTRU/DihKUhy/Y6zBPSz9pcXjtUIoJr7OyO95EfWISy1rsl SCGinhVGUZIODahUqv3kWUdAWcVpmoRg5V5j2G7zZbm47hCQHpHtEx3lGyIn66oPqc+7 eH03VhbQALEo5Nn2VZYLuqbexppjH+6JhiEDX2afI13bhsYqman3LW2Ov7EweOeflI7v RqHZkX16Ku75jE65rBv7FnSCrGDh59UdnAK6LXPnbEtEGBLYH2/z1+Ws2fhmdL9oKPUW y3og== X-Gm-Message-State: AO0yUKVeIvsWp0rAYlEC2fG9DBhide17PAKeKLsHzhDURK4LNOV8UUwm TP1oDFeV6nk11JogpxBB07k= X-Google-Smtp-Source: AK7set/ReVgsBimOlwblOVCHyuXiu9TrInYLe7K4a9xM5drFddNdv+siJaqdPcjLVv0fJ5Gm+5janA== X-Received: by 2002:a62:7958:0:b0:5a8:c693:c7b4 with SMTP id u85-20020a627958000000b005a8c693c7b4mr7676073pfc.30.1677713196085; Wed, 01 Mar 2023 15:26:36 -0800 (PST) Received: from nathanxps13 ([50.47.162.83]) by smtp.gmail.com with ESMTPSA id z19-20020aa785d3000000b005a8a9950363sm8422294pfn.105.2023.03.01.15.26.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Mar 2023 15:26:35 -0800 (PST) Date: Wed, 1 Mar 2023 15:26:33 -0800 From: Nathan Bossart To: Andres Freund Cc: Thomas Munro , Michael Paquier , Robert Haas , Tom Lane , Fujii Masao , Postgres hackers Subject: Re: stopgap fix for signal handling during restore_command Message-ID: <20230301232633.GA1825532@nathanxps13> References: <20230225190742.lfopue3nkrvxxoie@awork3.anarazel.de> <20230225192825.GA868928@nathanxps13> <20230225195253.hzp6pyllhn4kw4g6@awork3.anarazel.de> <20230225220629.GA1021641@nathanxps13> <20230226180029.djk7cth4o3o5doom@awork3.anarazel.de> <20230226193900.GA1248604@nathanxps13> <20230226201227.cner3cdicropu4q5@awork3.anarazel.de> <20230301043603.GD1453450@nathanxps13> <20230301224751.GA1823946@nathanxps13> <20230301231304.bariubyihe4iv53o@awork3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230301231304.bariubyihe4iv53o@awork3.anarazel.de> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Mar 01, 2023 at 03:13:04PM -0800, Andres Freund wrote: > FWIW, I think we could rely on va_start() et al to be signal safe. The > standardese isn't super clear about this, because they aren't functions, and > posix only talks about functions being async signal safe... Good to know. I couldn't tell whether that was a safe assumption from briefly reading around. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com