Date: Mon, 06 Mar 2023 15:48:43 +0900 (JST)
Message-Id: <20230306.154843.178021884584228317.horikyota.ntt@gmail.com>
To: tgl@sss.pgh.pa.us
Cc: andres@anarazel.de, melanieplageman@gmail.com, vignesh21@gmail.com,
 pryzby@telsasoft.com, lukas@fittl.com, alvherre@alvh.no-ip.org,
 magnus@hagander.net, pgsql-hackers@postgresql.org, thomas.munro@gmail.com,
 m.sakrejda@gmail.com
Subject: Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and
 more?)
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: <20230306.152425.316894602450485455.horikyota.ntt@gmail.com>
References: <20230211182437.ype5tk3awen2htvw@awork3.anarazel.de>
	<3039228.1677972069@sss.pgh.pa.us>
	<20230306.152425.316894602450485455.horikyota.ntt@gmail.com>
User-Agent: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Multipart/Mixed;
 boundary="--Next_Part(Mon_Mar__6_15_48_43_2023_422)--"
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/20230306.154843.178021884584228317.horikyota.ntt%40gmail.com>
Precedence: bulk

----Next_Part(Mon_Mar__6_15_48_43_2023_422)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

At Mon, 06 Mar 2023 15:24:25 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in 
> In any case, I think we need to avoid such concurrent autovacuum/analyze.

If it is correct, I believe the attached fix works.

regads.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center

----Next_Part(Mon_Mar__6_15_48_43_2023_422)--
Content-Type: Text/X-Patch; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="fix_stats_test.diff"

diff --git a/src/test/regress/expected/stats.out b/src/test/regress/expected/stats.out
index 937b2101b3..023ec5ecc4 100644
--- a/src/test/regress/expected/stats.out
+++ b/src/test/regress/expected/stats.out
@@ -1137,7 +1137,7 @@ SELECT pg_stat_get_subscription_stats(NULL);
 -- extends.
 SELECT sum(extends) AS io_sum_shared_before_extends
   FROM pg_stat_io WHERE io_context = 'normal' AND io_object = 'relation' \gset
-CREATE TABLE test_io_shared(a int);
+CREATE TABLE test_io_shared(a int) WITH (autovacuum_enabled = 'false');
 INSERT INTO test_io_shared SELECT i FROM generate_series(1,100)i;
 SELECT pg_stat_force_next_flush();
  pg_stat_force_next_flush 
diff --git a/src/test/regress/sql/stats.sql b/src/test/regress/sql/stats.sql
index 74e592aa8a..aa6552befd 100644
--- a/src/test/regress/sql/stats.sql
+++ b/src/test/regress/sql/stats.sql
@@ -549,7 +549,7 @@ SELECT pg_stat_get_subscription_stats(NULL);
 -- extends.
 SELECT sum(extends) AS io_sum_shared_before_extends
   FROM pg_stat_io WHERE io_context = 'normal' AND io_object = 'relation' \gset
-CREATE TABLE test_io_shared(a int);
+CREATE TABLE test_io_shared(a int) WITH (autovacuum_enabled = 'false');
 INSERT INTO test_io_shared SELECT i FROM generate_series(1,100)i;
 SELECT pg_stat_force_next_flush();
 SELECT sum(extends) AS io_sum_shared_after_extends

----Next_Part(Mon_Mar__6_15_48_43_2023_422)----