Date: Tue, 7 Mar 2023 10:47:09 +0800
From: Julien Rouhaud <rjuju123@gmail.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: "Gregory Stark (as CFM)" <stark.cfm@gmail.com>,
	Pavel Stehule <pavel.stehule@gmail.com>,
	Justin Pryzby <pryzby@telsasoft.com>,
	Andres Freund <andres@anarazel.de>,
	Andrew Dunstan <andrew@dunslane.net>,
	John Naylor <john.naylor@enterprisedb.com>,
	Erik Rijkers <er@xs4all.nl>, Tom Lane <tgl@sss.pgh.pa.us>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	Tomas Vondra <tomas.vondra@enterprisedb.com>,
	Dean Rasheed <dean.a.rasheed@gmail.com>,
	Stephen Frost <sfrost@snowman.net>,
	Surafel Temesgen <surafel3000@gmail.com>,
	vignesh C <vignesh21@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: proposal: possibility to read dumped table's name from file
Message-ID: <20230307024709.n3mky2yzttxxqaj4@jrouhaud>
References: <20221104121927.GZ16921@telsasoft.com>
 <20221104132830.yee7hyv6kzaz6kvv@jrouhaud>
 <CAFj8pRBB_9jdr8LoL9r-gQ9O1aRdPXXO0iH-HrYkC3jPgxY5Aw@mail.gmail.com>
 <20221111081125.bxtndzqlt5tpc5qw@jrouhaud>
 <CAFj8pRBmN1AGm7wBk8279_mf-vCd6vaiY+tJ=dOLrn9p1LAL8w@mail.gmail.com>
 <20221113085838.mcb7ai3p2ozxqjxa@jrouhaud>
 <CAFj8pRA_1rroP3TvM7xnpUb=U4Z085ZHL6HC5TjaETnj0ttirA@mail.gmail.com>
 <20221122052556.jkb3kmzg7k3g2b7h@jrouhaud>
 <CAM-w4HNSmKQKw0r3wm2qgt4dhoSMCSmyp6cfK2u8P0roA7m5ng@mail.gmail.com>
 <9069E332-4D38-4BBE-B527-3D9D4A11912E@yesql.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9069E332-4D38-4BBE-B527-3D9D4A11912E@yesql.se>
Archived-At: <https://www.postgresql.org/message-id/20230307024709.n3mky2yzttxxqaj4%40jrouhaud>
Precedence: bulk

Hi,

On Mon, Mar 06, 2023 at 10:20:32PM +0100, Daniel Gustafsson wrote:
> > On 6 Mar 2023, at 21:45, Gregory Stark (as CFM) <stark.cfm@gmail.com> wrote:
> >
> > So.... This patch has been through a lot of commitfests. And it really
> > doesn't seem that hard to resolve -- Pavel has seemingly been willing
> > to go along whichever way the wind has been blowing but honestly it
> > kind of seems like he's just gotten drive-by suggestions and he's put
> > a lot of work into trying to satisfy them.
>
> Agreed.

Indeed, I'm not sure I would have had that much patience.

> > He implemented --include-tables-from-file=... etc. Then he implemented
> > a hand-written parser for a DSL to select objects, then he implemented
> > a bison parser, then he went back to the hand-written parser.
>
> Well, kind of.  I was trying to take the patch to the finishing line but was
> uncomfortable with the hand written parser so I implemented a parser in Bison
> to replace it with.  Not that hand-written parsers are bad per se (or that my
> bison parser was perfect), but reading quoted identifiers across line
> boundaries tend to require a fair amount of handwritten code.  Pavel did not
> object to this version, but it was objected to by two other committers.
>
> At this point [0] I stepped down from trying to finish it as the approach I was
> comfortable didn't gain traction (which is totally fine).
>
> Downthread from this the patch got a lot of reviews from Julien with the old
> parser back in place.

Yeah, and the current state seems quite good to me.

> > Can we get some consensus on whether the DSL looks right
>
> I would consider this pretty settled.

Agreed.