Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pb9JL-0005zg-HH for pgsql-hackers@arkaria.postgresql.org; Sun, 12 Mar 2023 00:11:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pb9JJ-0002hK-Un for pgsql-hackers@arkaria.postgresql.org; Sun, 12 Mar 2023 00:11:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pb9JJ-0002hB-LQ for pgsql-hackers@lists.postgresql.org; Sun, 12 Mar 2023 00:11:37 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pb9JC-0002Iv-Le for pgsql-hackers@postgresql.org; Sun, 12 Mar 2023 00:11:37 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 2A8A3320055E; Sat, 11 Mar 2023 19:11:27 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Sat, 11 Mar 2023 19:11:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1678579886; x=1678666286; bh=wb oDAdaZTWCG1cvdVYvrBVM3qV/9YtYfrFXgVhZ2TIg=; b=hzzIl9sLhsmvxPCVSk +EMH63c5DmOsG+nyr92ClPhuVyE9Sr5Nk9swowx9obfdd7Ag+tmWh8w2C1EtSJSA HvGdO9a6GBan69tQeyJpEwvjowPqgEWAH7n9VvUH8Ezzflj5DlCZjNd/eQm38pD4 ruSKEuB5t9HI3lGV+RPqHdibKsmKb4egE7Vt3nsGHZXfald5OL6IOcQwmSjeZfeJ Gqi1qfDX9Q9Tea6mpiFsGFhcgqE+sDJ0XVT/IQSZlabUp5ptq4pp7oMgyh5nLrwD 2uFVF9ar4ljjkQ7G59a+Zn4g4/AczFlf6gZoxcSmb/Sn7ELJbZFUNqqBVET2jXpM zt9w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1678579886; x=1678666286; bh=wboDAdaZTWCG1 cvdVYvrBVM3qV/9YtYfrFXgVhZ2TIg=; b=e3My7GA15EL2beK6DbpM3hkzX9vD3 td595OyB8HteNWM2BRrm6jXDYYcvXalYdJotI4dr11Q/vZOJ2THlL9VAjqUUgRaq tti48pRYep4tVAg7s64JoWTLmat4T/sI31MxeDGjDX7HaPSkeZEw8a/DJy8N9GEH j9KdtQbrENYle0UzeorhTiLL4WXYvmVt+eHrSc/Pwf54F5nRBjvr7fi168sxVnqK By/yVNF4B8DFKIwLMPyRK4rH3vw+B0mMLls0QGRgKM0C7d7FTOFmdx/izhCaBgJO 5L+PPk5fcSJ0kIKNawiLS20CsZB3pdTDpEfMdK0ST/Vi9VCGu/96r1uqg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddvuddgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepvdfffeevhfetveffgeeiteefhfdtvdffjeevhfeuteegleduheetvedu ieettddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 11 Mar 2023 19:11:26 -0500 (EST) Date: Sat, 11 Mar 2023 16:11:25 -0800 From: Andres Freund To: Peter Eisentraut Cc: pgsql-hackers Subject: Re: Transparent column encryption Message-ID: <20230312001125.ijeu4imbwlhj5flf@awork3.anarazel.de> References: <75f394fa-f539-1875-079c-c654deceed41@enterprisedb.com> <8bcedb49-1496-0755-bd24-1cbabf30ec84@enterprisedb.com> <1034b6f1-ccab-8a22-c843-71104ebedf01@enterprisedb.com> <40c43d0d-ae4b-fe34-2667-771b3718384e@enterprisedb.com> <47e17f03-6595-6c09-8978-7a1581cad6f2@enterprisedb.com> <7a430d89-233b-5cd7-6892-9fed06695d39@enterprisedb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7a430d89-233b-5cd7-6892-9fed06695d39@enterprisedb.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2023-03-10 08:18:34 +0100, Peter Eisentraut wrote: > Here is an updated patch. I have done some cosmetic polishing and fixed a > minor Windows-related bug. > > In my mind, the patch is complete. > > If someone wants to do some in-depth code review, I suggest focusing on the > following files: > > * src/backend/access/common/printtup.c Have you done benchmarks of some simple workloads to verify this doesn't cause slowdowns (when not using encryption, obviously)? printtup.c is a performance sensitive portion for simple queries, particularly when they return multiple columns. And making tupledescs even wider is likely to have some price, both due to the increase in memory usage, and due to the lower cache density - and that's code where we're already hurting noticeably. Greetings, Andres Freund