Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pb9K8-00061k-RH
	for pgsql-hackers@arkaria.postgresql.org; Sun, 12 Mar 2023 00:12:28 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pb9K7-0005Sg-NT
	for pgsql-hackers@arkaria.postgresql.org; Sun, 12 Mar 2023 00:12:27 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <andres@anarazel.de>)
	id 1pb9K7-0005SX-EO
	for pgsql-hackers@lists.postgresql.org; Sun, 12 Mar 2023 00:12:27 +0000
Received: from wout1-smtp.messagingengine.com ([64.147.123.24])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <andres@anarazel.de>)
	id 1pb9K5-0002KE-2b
	for pgsql-hackers@lists.postgresql.org; Sun, 12 Mar 2023 00:12:27 +0000
Received: from compute6.internal (compute6.nyi.internal [10.202.2.47])
	by mailout.west.internal (Postfix) with ESMTP id D663E320055E;
	Sat, 11 Mar 2023 19:12:22 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
  by compute6.internal (MEProxy); Sat, 11 Mar 2023 19:12:23 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h=
	cc:cc:content-type:content-type:date:date:from:from:in-reply-to
	:in-reply-to:message-id:mime-version:references:reply-to:sender
	:subject:subject:to:to; s=fm2; t=1678579942; x=1678666342; bh=Dr
	i1k/er92b1XkAICsCjDX7GtQRSmE2J4lnpa1Phi/U=; b=LE2vfYhehvrmgzKgRy
	mCtrem7YqtsCaxiYekOQQNlFx9tzDsiFsuhC7OrpoPMlTyPX9SuhQ4dpewmfnpzP
	ky//s3b+jNIfDdWpBiAMQZRM63Xs9TDIOcrQmYMvlV9YuK7Fjmhxw+nX6+gP/8ni
	qp/FGx45P009OEheOmFFx8bQZnM88xkXJJQ6alPrD5AFBu5t5UKUSQ+4pwI1eJWh
	wYDhxMrAmM4HSUCw3uGDAxBXors6R2wqo+xvMPqVQVUUMug9OTk4y7aJ6Wt1gCy5
	XuzKj41cGFySlwiOu8z1RRFLzyQmmCIb0ZRP7KErHmw5jGN8g9HlcBKi6YoCzsiv
	bisw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:content-type:date:date
	:feedback-id:feedback-id:from:from:in-reply-to:in-reply-to
	:message-id:mime-version:references:reply-to:sender:subject
	:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
	:x-sasl-enc; s=fm2; t=1678579942; x=1678666342; bh=Dri1k/er92b1X
	kAICsCjDX7GtQRSmE2J4lnpa1Phi/U=; b=lkpUM3YSXObQqZJ6QXQINPEBfDjAo
	7GMjcdYVn5wMMWKgois//kQAtxES11drMOKBGOZeL+prO4Fe9SAbfsLY10VNlUyh
	K5rHKkNxXxyrtGcXFoxlp8fqbGIaoyARhGkQU/w9RYKCzbv8jr5AxvE0tSO0yqjI
	PHUxoOCMcF+LuJI6tIdJLEZcPTZgEK/H9zPc2GSWcZ++U8ne5OHk2pwHENDirJyW
	YBR/7DH7qJccgflayTEeIyy8WH9WiRLDo5gxaAsR3aj0160SbkpPJrf3TYePrr8m
	0Y/9hesblT3ZbO9r+gaw7otTkObwdUdciqrA5ZeXEJDT/5PI+jFcPoB6Q==
X-ME-Sender: <xms:5hgNZOOCT0Kkp2dAI9AEBrRGOA7IEUHN1Hp21L-XP0lDMMZo8cZ6ew>
    <xme:5hgNZM_IrHbdNA35v1sR4s1UArrIVXOOUWVJyDG8A8U29w6PxLoHyx9EUh4deyTCc
    QDJzEYF0lVALUJhQQ>
X-ME-Received: <xmr:5hgNZFTSL1wzPSgaSe4OKmyEWzgWOoB_y_lxGQGYvHUlXe0UabVr3NDKl14dr5A0TaMJop9kA9YCzqPukm4bQPyZildmiV8HomCj5F-yPKYt76Z4gZu79AzyuVk5>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddvuddgudelucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomheptehnughr
    vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf
    grthhtvghrnhepgfdvvdeitdfhhedvudetfeffvdejjeduveetkeevkeegfeejkeelveei
    teektddtnecuffhomhgrihhnpehmvghsohhnrdgsuhhilhgunecuvehluhhsthgvrhfuih
    iivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghnughrvghssegrnhgrrhgriigv
    lhdruggv
X-ME-Proxy: <xmx:5hgNZOtxpzl1jyaa7kNktesQ7zTVR3qxcFnlYECuBP_UDSWrHp1a1Q>
    <xmx:5hgNZGdnjAcK8-6n95xSASIYC3Wj4M0cWzgkScDPHpVb96TYZDt8RQ>
    <xmx:5hgNZC0tiYFEvH31A-TsGVbfsqGebhyhmKR7QQIhWl2NgntB33COog>
    <xmx:5hgNZOllPVAgHlf9NxN4zpLrJpPabBPcY7oLR-fs0crAp0UMuUksFQ>
Feedback-ID: id4a34324:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat,
 11 Mar 2023 19:12:22 -0500 (EST)
Date: Sat, 11 Mar 2023 16:12:21 -0800
From: Andres Freund <andres@anarazel.de>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: unsafe_tests module
Message-ID: <20230312001221.q6dgdnvj33uxik5x@awork3.anarazel.de>
References: <be869e1c-8e3f-4cde-8609-212c899cccf9@dunslane.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <be869e1c-8e3f-4cde-8609-212c899cccf9@dunslane.net>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/20230312001221.q6dgdnvj33uxik5x%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2023-02-22 06:47:34 -0500, Andrew Dunstan wrote:
> Given its nature and purpose as a module we don't want to run against an
> installed instance, shouldn't src/test/modules/unsafe_tests have
> NO_INSTALLCHECK=1 in its Makefile and runningcheck:false in its meson.build?

Seems like a good idea to me.

Greetings,

Andres Freund