Date: Mon, 13 Mar 2023 12:59:16 +0100
From: 'Sandro Santilli' <strk@kbt.io>
Sender: strk@kbt.io
To: Regina Obe <lr@pcorp.us>
Cc: 'Tom Lane' <tgl@sss.pgh.pa.us>,
	"'Gregory Stark (as CFM)'" <stark.cfm@gmail.com>,
	pgsql-hackers@lists.postgresql.org, 'Regina Obe' <r@pcorp.us>
Subject: Re: Ability to reference other extensions by schema in extension
 scripts
Message-ID: <20230313115916.ivvg4tj54szeu5rj@c19>
References: <000401d94bc8$48dff700$da9fe500$@pcorp.us>
 <167762779361.628976.14009177203307564086.pgcf@coridan.postgresql.org>
 <CAM-w4HP91M-r=h4nExwonHf03SRwKyNYnvFHX2FFoFMv0pRQBA@mail.gmail.com>
 <005401d95083$26ca24a0$745e6de0$@pcorp.us>
 <995823.1678478825@sss.pgh.pa.us>
 <004b01d95394$16123ee0$4236bca0$@pcorp.us>
 <1012975.1678486476@sss.pgh.pa.us>
 <005501d953a0$906c4df0$b144e9d0$@pcorp.us>
 <1019515.1678488437@sss.pgh.pa.us>
 <001d01d953f2$099b6430$1cd22c90$@pcorp.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <001d01d953f2$099b6430$1cd22c90$@pcorp.us>
Archived-At: <https://www.postgresql.org/message-id/20230313115916.ivvg4tj54szeu5rj%40c19>
Precedence: bulk

On Sat, Mar 11, 2023 at 03:18:18AM -0500, Regina Obe wrote:
> Attached is a revised patch with these changes in place.

I've given a try to this patch. It builds and regresses fine.

My own tests also worked fine. As long as ext1 was found
in the ext2's no_relocate list it could not be relocated,
and proper error message is given to user trying it.

Nitpicking, there are a few things that are weird to me:

1) I don't get any error/warning if I put an arbitrary
string into no_relocate (there's no check to verify the
no_relocate is a subset of the requires).

2) An extension can still reference extensions it depends on
without putting them in no_relocate. This may be intentional,
as some substitutions may not require blocking relocation, but
felt inconsistent with the normal @extschema@ which is never
replaced unless an extension is marked as non-relocatable.

--strk;

  Libre GIS consultant/developer
  https://strk.kbt.io/services.html