Feedback-ID: id4a34324:Fastmail
Date: Mon, 13 Mar 2023 13:14:56 -0700
From: Andres Freund <andres@anarazel.de>
To: Nazir Bilal Yavuz <byavuz81@gmail.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Daniel Gustafsson <daniel@yesql.se>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: meson: Non-feature feature options
Message-ID: <20230313201456.k2u64icabmn4l2e2@awork3.anarazel.de>
References: <CAN55FZ3JkWJRgBOvaB0VDYg1F+v3QMg4vwVae1gpQ+mnsYc-3g@mail.gmail.com>
 <b695b531-eb98-87f1-45c8-13f2ed3973a8@enterprisedb.com>
 <CAN55FZ1UFQfKifUV=oAf+WseCxD0Kq3g_AvWEEety9VneMvzvw@mail.gmail.com>
 <0fff0827-c1f5-d29c-2ee3-dc8c871176bf@enterprisedb.com>
 <CAN55FZ1=-jb38PujfcMWjAH8vDTYoxrgvz_oha_p+q0quMtzCw@mail.gmail.com>
 <9df9067d-5651-2d3e-e838-9e5d273f5524@enterprisedb.com>
 <5250E85B-4A97-4DA1-8900-7DCDE925441A@yesql.se>
 <6d3310fb-50e3-34d8-fe10-8dd8c4ffdf23@enterprisedb.com>
 <20230313180432.GA246741@nathanxps13>
 <CAN55FZ0Jsqq=UNMX+RA7G1GZGvZuJP_YwKKK5mNaEj8mbq2Z7Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAN55FZ0Jsqq=UNMX+RA7G1GZGvZuJP_YwKKK5mNaEj8mbq2Z7Q@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/20230313201456.k2u64icabmn4l2e2%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2023-03-13 21:57:22 +0300, Nazir Bilal Yavuz wrote:
> On Mon, 13 Mar 2023 at 21:04, Nathan Bossart <nathandbossart@gmail.com> wrote:
> >
> > On Mon, Mar 13, 2023 at 07:27:18AM +0100, Peter Eisentraut wrote:
> > > I have committed it like this.
> >
> > I noticed that after 6a30027, if you don't have the OpenSSL headers
> > installed, 'meson setup' will fail:
> >
> >         meson.build:1195:4: ERROR: C header 'openssl/ssl.h' not found
> >
> > Shouldn't "auto" cause Postgres to be built without OpenSSL if the required
> > headers are not present?
> 
> Yes, I tested again and it is working as expected on my end. It
> shouldn't fail like that unless the 'ssl' option is set to 'openssl'.
> Is it possible that it has been set to 'openssl' without you noticing?

It worked for the dependency() path, but not the cc.find_library() path. See
the patch I just sent.

Greetings,

Andres Freund