Date: Thu, 16 Mar 2023 11:14:18 +0100
From: Sandro Santilli <strk@kbt.io>
Sender: strk@kbt.io
To: Regina Obe <lr@pcorp.us>
Cc: 'Tom Lane' <tgl@sss.pgh.pa.us>,
	"'Gregory Stark (as CFM)'" <stark.cfm@gmail.com>,
	pgsql-hackers@lists.postgresql.org, 'Regina Obe' <r@pcorp.us>
Subject: Re: Ability to reference other extensions by schema in extension
 scripts
Message-ID: <20230316101418.2a32erangr3nvnuk@c19>
References: <CAM-w4HP91M-r=h4nExwonHf03SRwKyNYnvFHX2FFoFMv0pRQBA@mail.gmail.com>
 <005401d95083$26ca24a0$745e6de0$@pcorp.us>
 <995823.1678478825@sss.pgh.pa.us>
 <004b01d95394$16123ee0$4236bca0$@pcorp.us>
 <1012975.1678486476@sss.pgh.pa.us>
 <005501d953a0$906c4df0$b144e9d0$@pcorp.us>
 <1019515.1678488437@sss.pgh.pa.us>
 <001d01d953f2$099b6430$1cd22c90$@pcorp.us>
 <20230313115916.ivvg4tj54szeu5rj@c19>
 <000701d955f6$dfaaf8a0$9f00e9e0$@pcorp.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <000701d955f6$dfaaf8a0$9f00e9e0$@pcorp.us>
Archived-At: <https://www.postgresql.org/message-id/20230316101418.2a32erangr3nvnuk%40c19>
Precedence: bulk

On Mon, Mar 13, 2023 at 05:57:57PM -0400, Regina Obe wrote:
> 
> Attached is a slightly revised patch to fix the extra whitespace in the
> extend.gml document that Sandro noted to me.

Thanks Regina.
I've tested attached patch (md5 0b652a8271fc7e71ed5f712ac162a0ef)
against current master (hash 4ef1be5a0b676a9f030cc2e4837f4b5650ecb069).
The patch applies cleanly, builds cleanly, regresses cleanly.

I've also run my quick test and I'm satisfied with it:

  test=# create extension ext2 cascade;
  NOTICE:  installing required extension "ext1"
  CREATE EXTENSION

  test=# select ext2log('h');
  ext1: ext2: h

  test=# alter extension ext1 set schema n1;
  ERROR:  cannot SET SCHEMA of extension ext1 because other extensions prevent it
  DETAIL:  extension ext2 prevents relocation of extension ext1

  test=# drop extension ext2;
  DROP EXTENSION

  test=# alter extension ext1 set schema n1;
  ALTER EXTENSION

  test=# create extension ext2;
  CREATE EXTENSION

  test=# select ext2log('h');
  ext1: ext2: h


--strk;