Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcvXa-0000iU-9x for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Mar 2023 21:53:43 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pcvXW-0004wq-Ah for pgsql-hackers@arkaria.postgresql.org; Thu, 16 Mar 2023 21:53:38 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcvXU-0004w4-K2 for pgsql-hackers@lists.postgresql.org; Thu, 16 Mar 2023 21:53:38 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcvXR-0006HP-99 for pgsql-hackers@lists.postgresql.org; Thu, 16 Mar 2023 21:53:35 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id CD9075C00DF; Thu, 16 Mar 2023 17:53:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 16 Mar 2023 17:53:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1679003611; x=1679090011; bh=h4 9EX+/MtqojSbw7cwLEdIo9mjNO3J7tFNhWYynHjVc=; b=MzF3zSBn8FTsmC6DdA ZXhwgd4Zg+FQGfmVYXuOlaC/FwrUu/F2V49Qc0XBvY5knvTDpsUb+iGw2j0A9lO6 McO+2o9ob3Y6RYzdmxCwWkVQACJOeJ1TcRId9BNrXjB2/8nNCYSGlGh02FOCVVfW CThgXbIKt5XKCWhy7HlhIQt3jqiW/sOMJHMTOcH32ylbF1dXrKHlS4Yigbt/o+6a edfq0F0vPFXcscYPBefyYzymUO6XflIfmq8k2mE+EUY8OimPjYboajzjDIHm1fin I2mBRpJ2aTsuq5/EUn1Oc0NUOp8XKc/PZMLfA+yu/oUT6+UBSFp9hk51tKVRjprL eoJA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1679003611; x=1679090011; bh=h49EX+/MtqojS bw7cwLEdIo9mjNO3J7tFNhWYynHjVc=; b=cUeML3hUB1/rCOUBpOkPGrnXjCCfO rwCPXDYT3e0pDxXFOdv1avm9gTomNEG8aUzcLx4htYONdGFrxr6S9RrceheleMmo 0hX/E70jLPPXXe7gKVBFC2lKAI4v/9m8h8hlVVRiIw7rpF6OPB8/D+0pjRlHrVmx fJr2tzB5l6edpdKRTVGHOUuRU0kDByb9xl2ysI0hqzOwcNNlHhjHD/IucQXAtuQW YVWgv+mAkgCf+Q5HS+Rh4bPVfiNysYrD7ni7CBj74N0N7Xr0XmoAz7W9Z1/ySUbu oekRaBvTXDHtZaUmKoiC94ZwXxITfna3c0UGD5r8y9yDlvqnVe+rDZ4Sg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeftddgudehiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvfevuffkfhggtggujgesth dtredttddtvdenucfhrhhomheptehnughrvghsucfhrhgvuhhnugcuoegrnhgurhgvshes rghnrghrrgiivghlrdguvgeqnecuggftrfgrthhtvghrnhepudegieeftdekteeijedugf euhfegjeeuhfelvdeuheduvdeugefhkeelfeeiteevnecuffhomhgrihhnpehgohgusgho lhhtrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homheprghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 16 Mar 2023 17:53:31 -0400 (EDT) Date: Thu, 16 Mar 2023 14:53:30 -0700 From: Andres Freund To: Tom Lane Cc: pgsql-hackers@lists.postgresql.org Subject: Re: More weird compiler warnings Message-ID: <20230316215330.ujnmihwp5uuinvos@awork3.anarazel.de> References: <144536.1648326206@sss.pgh.pa.us> <20220326205549.mwwlx7cejdght7bf@alap3.anarazel.de> <20230316171846.2yurkzkibrkn566t@awork3.anarazel.de> <3959491.1678991497@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3959491.1678991497@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2023-03-16 14:31:37 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2022-03-26 13:55:49 -0700, Andres Freund wrote: > >> On 2022-03-26 16:23:26 -0400, Tom Lane wrote: > >>> but I'm wondering if we could silence the warning by changing the loop condition to > >>> while (--nb >= 0) > >>> which seems like it might be marginally more readable anyway. > > >> Yes, that looks like it silences it. I modified the small reproducer I had in > >> that bug (https://godbolt.org/z/ejK9h6von) and the warning vanishes. > > > The recent discussion about warnings reminded me of this. Given the gcc bug > > hasn't been fixed, I think we should make that change. I'd vote for > > backpatching it as well - what do you think? > > +1, can't hurt anything AFAICS. Done.