Date: Mon, 20 Mar 2023 18:05:41 +0900 (JST)
Message-Id: <20230320.180541.96678678678426257.horikyota.ntt@gmail.com>
To: bharath.rupireddyforpostgres@gmail.com
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Fix misplaced shared_preload_libraries_in_progress check in
 few extensions
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: <CALj2ACVH1BA+GrADan=6oBJR_Dc9-3mBgWsK0CqubT+WNOjQgg@mail.gmail.com>
References: <CALj2ACVH1BA+GrADan=6oBJR_Dc9-3mBgWsK0CqubT+WNOjQgg@mail.gmail.com>
User-Agent: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/20230320.180541.96678678678426257.horikyota.ntt%40gmail.com>
Precedence: bulk

At Sat, 18 Mar 2023 10:26:42 +0530, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote in 
> Hi,
> 
> I'm attaching a patch to do $subject in autoprewarm.c and worker_spi
> extensions. The way it is right now doesn't hurt anyone, but why to
> fail after defining custom GUCs if we aren't loading them via
> shared_preload_libraries.
> 
> Thoughts?

I don't think they're misplaced at least for pg_prewram. pg_prewarm
worker allows to be executed after startup and the variable is still
used by such prewarm worker processes, but the patch make the variable
stop working in that case.

I didn't look at the part for worker_spi.c.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center