Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1peb4Z-0005QG-G1 for pgsql-hackers@arkaria.postgresql.org; Tue, 21 Mar 2023 12:26:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1peb4Y-0001wR-Ce for pgsql-hackers@arkaria.postgresql.org; Tue, 21 Mar 2023 12:26:38 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1peb4X-0001wI-AU for pgsql-hackers@lists.postgresql.org; Tue, 21 Mar 2023 12:26:38 +0000 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1peb4U-0006Ak-5y for pgsql-hackers@lists.postgresql.org; Tue, 21 Mar 2023 12:26:36 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 598373200954; Tue, 21 Mar 2023 08:26:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 21 Mar 2023 08:26:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1679401590; x= 1679487990; bh=RJAsPy/dkFctsLxsITj9Z1OfxV7niIW1znOf3iCIyTw=; b=V tmR9/HrWnJE/vESk89/SVy/5/6Vf3ONO3rRptNojfv7OeQfcwv7IyPxL24tj24en EWYQ7aEr7oJzb4GS9qEJcAdoro8+CgWU6Y4F/RcbOqRCPXHprHJWxp+ct8TRLJ0i UyUNn4J9NuiYdydhMp3/aYiIMBd8w4Vf9n7FrbVYaDsI39QV2D3QIiCHEOGqYbh/ LyuLtSwJiwBUBGiCz+VV4TEFFJAEy6a1PSxzpTxGp+R7hvMZ863TF01Kji9uASOh OA73mQlsO9gC1ZJgaFSW2vBN+BtllySO/wqSRTqY7lPQEaFNRB5CsxRZ1HNhtuGJ EJZSzlmaqA24ScsGEUVYA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdegtddgfeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkgggtugfgjgesthekredttddtjeenucfhrhhomheptehlvhgr rhhoucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh eqnecuggftrfgrthhtvghrnhepvdektdffudfftdffffehfffhjeejhffgieeuueekjeek fffgudffhfduffffueevnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhv hhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Feedback-ID: ia2694551:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 21 Mar 2023 08:26:30 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id CA846386; Tue, 21 Mar 2023 13:26:27 +0100 (CET) Date: Tue, 21 Mar 2023 13:26:27 +0100 From: Alvaro Herrera To: Dean Rasheed Cc: Vik Fearing , PostgreSQL Hackers Subject: Re: MERGE ... WHEN NOT MATCHED BY SOURCE Message-ID: <20230321122627.6hchobk4c6jn633q@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2023-Mar-21, Dean Rasheed wrote: > Looking at it with fresh eyes though, I realise that I could have just written > > action->qual = make_and_qual((Node *) ntest, action->qual); > > which is equivalent, but more concise. Nice. I have no further observations about this patch. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/