Feedback-ID: id4a34324:Fastmail
Date: Tue, 21 Mar 2023 09:43:23 -0700
From: Andres Freund <andres@anarazel.de>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Save a few bytes in pg_attribute
Message-ID: <20230321164323.mjaso2jffu2cj2dp@awork3.anarazel.de>
References: <d07ffc2b-e0e8-77f7-38fb-be921dff71af@enterprisedb.com>
 <933390.1679323056@sss.pgh.pa.us>
 <20230320234457.s2magjpvmeqg6nqe@awork3.anarazel.de>
 <1110938.1679356272@sss.pgh.pa.us>
 <f97a8cd0-009d-4a13-3317-1273a7de35f1@enterprisedb.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f97a8cd0-009d-4a13-3317-1273a7de35f1@enterprisedb.com>
Archived-At: <https://www.postgresql.org/message-id/20230321164323.mjaso2jffu2cj2dp%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2023-03-21 17:36:48 +0100, Peter Eisentraut wrote:
> On 21.03.23 00:51, Tom Lane wrote:
> > Andres Freund <andres@anarazel.de> writes:
> > > On 2023-03-20 10:37:36 -0400, Tom Lane wrote:
> > > > I agree that attinhcount could be narrowed, but I have some concern
> > > > about attstattarget.  IIRC, the limit on attstattarget was once 1000
> > > > and then we raised it to 10000.  Is it inconceivable that we might
> > > > want to raise it to 100000 someday?
> > 
> > > Hard to believe that'd happen in a minor version - and I don't think there'd
> > > an issue with widening it again in a major version?
> > 
> > True.  However, I think Tomas' idea of making these columns nullable
> > is even better than narrowing them.

Why not do both?


> The context of my message was to do the proposed change for PG16 to buy back
> a few bytes that are being added by another feature

How much would you need to buy back to "reach parity"?

Greetings,

Andres Freund