Feedback-ID: ia2694551:Fastmail
Date: Thu, 23 Mar 2023 10:35:55 +0100
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: "Karl O. Pinc" <kop@karlpinc.com>
Cc: Brar Piening <brar@gmx.de>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, vignesh C <vignesh21@gmail.com>,
	Ian Lawrence Barwick <barwick@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: doc: add missing "id" attributes to extension packaging page
Message-ID: <20230323093555.3icw7zetwtmtrrzu@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230322220919.17da355b@slate.karlpinc.com>
Archived-At: <https://www.postgresql.org/message-id/20230323093555.3icw7zetwtmtrrzu%40alvherre.pgsql>
Precedence: bulk

Thanks, Brar and Karl, I hope we can get this done soon.

As with the <simplelist> patch, we'll need to patch the CSS used in the
website for the docs too, as that's the most important place where docs
are visited.  See this commit for an example:
https://git.postgresql.org/gitweb/?p=pgweb.git;a=commitdiff;h=0b89ea0fff28d29ed177c82a274144453e3c7f82

In order to test locally that your patched stylesheet works correctly,
you'd have to compile the docs with "make html STYLE=website" in the doc
subdir, and tweak one of the CSS files there (I think it's
docs-complete.css) so that it references your local copy instead of
fetching it from the website.

> diff --git a/doc/src/sgml/stylesheet.css b/doc/src/sgml/stylesheet.css
> index cc14efa1ca..15bcc95d41 100644
> --- a/doc/src/sgml/stylesheet.css
> +++ b/doc/src/sgml/stylesheet.css
> @@ -169,3 +169,13 @@ acronym		{ font-style: inherit; }
>      width: 75%;
>    }
>  }
> +
> +/* Links to ids of headers and definition terms */
> +a.id_link {
> +        color: inherit;
> +        visibility: hidden;
> +}
> +
> +*:hover > a.id_link {
> +        visibility: visible;
> +}

I'm not clear on what exactly becomes visible when one hovers over what.
Can you please share a screenshot?

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/