Date: Thu, 23 Mar 2023 17:55:30 -0500
From: "Karl O. Pinc" <kop@karlpinc.com>
To: Brar Piening <brar@gmx.de>
Cc: Corey Huinker <corey.huinker@gmail.com>, Alvaro Herrera
 <alvherre@alvh.no-ip.org>, Peter Eisentraut
 <peter.eisentraut@enterprisedb.com>, Tom Lane <tgl@sss.pgh.pa.us>, vignesh
 C <vignesh21@gmail.com>, Ian Lawrence Barwick <barwick@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: doc: add missing "id" attributes to extension packaging page
Message-ID: <20230323175530.2001f237@slate.karlpinc.com>
In-Reply-To: <20230323173123.68b5cd8f@slate.karlpinc.com>
References: <20230323093555.3icw7zetwtmtrrzu@alvherre.pgsql>
	<a41ed60d-2f95-da52-ba8b-b0b1cc37f3a4@gmx.de>
	<CADkLM=d16C_aG2UZLTnZ+_D_od1ysh2Atm-=-uOiY8wfRyZyUA@mail.gmail.com>
	<20230323173123.68b5cd8f@slate.karlpinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/20230323175530.2001f237%40slate.karlpinc.com>
Precedence: bulk

This is for the committer, as an FYI.

I cut out the <xsl:template name="section.heading"> portion
of the docbook XSLT and diffed it with the code for the
same template in the patch.  The diff looks like:

-- /tmp/sections.xsl	2023-03-22 13:00:33.432968357 -0500
+++ /tmp/make_html_ids_discoverable_v3.patch	2023-03-22 13:03:39.776930603 -0500
@@ -52,5 +52,8 @@
       </xsl:call-template>
     </xsl:if>
     <xsl:copy-of select="$title"/>
+    <xsl:call-template name="pg.id.link">
+      <xsl:with-param name="object" select="$section"/>
+    </xsl:call-template>
   </xsl:element>
 </xsl:template>

(So, this output would start with line 52 of the template,
not from the top of the stock sections.xsl file.)

However, I am not really familiar with exactly what flavor
of docbook, version, namespace-d or not, etc., that PG
uses.  So I could be diffing with the wrong thing.

Hope this helps and is not just noise.

Regards,

Karl <kop@karlpinc.com>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein