Feedback-ID: ia2694551:Fastmail
Date: Wed, 29 Mar 2023 12:27:58 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Erik Rijkers <er@xs4all.nl>
Cc: Andrew Dunstan <andrew@dunslane.net>,
	Amit Langote <amitlangote09@gmail.com>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Andres Freund <andres@anarazel.de>, vignesh C <vignesh21@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
	e.indrupskaya@postgrespro.ru
Subject: Re: SQL/JSON revisited
Message-ID: <20230329102758.trybzdwbwajrf4mv@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <91cf8a3a-efc9-9e1c-351e-0f81677dc79f@xs4all.nl>
Archived-At: <https://www.postgresql.org/message-id/20230329102758.trybzdwbwajrf4mv%40alvherre.pgsql>
Precedence: bulk

On 2023-Mar-28, Erik Rijkers wrote:

> In the json_arrayagg() description, it says:
> 'If ABSENT ON NULL is specified, any NULL values are omitted.'
> That's true, but as omitting NULL values is the default (i.e., also without
> that clause) maybe it's better to say:
> 'Any NULL values are omitted unless NULL ON NULL is specified'

Doh, somehow I misread your report and modified the json_object()
documentation instead after experimenting with it (so now the
ABSENT/NULL ON NULL clause is inconsistenly described everywhere).
Would you mind submitting a patch fixing this mistake?

... and pushed it now, after some more meddling.

I'll rebase the rest of the series now.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"Entristecido, Wutra                     (canción de Las Barreras)
echa a Freyr a rodar
y a nosotros al mar"