Feedback-ID: id4a34324:Fastmail
Date: Sun, 2 Apr 2023 14:35:06 -0700
From: Andres Freund <andres@anarazel.de>
To: Jeff Davis <pgsql@j-davis.com>
Cc: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>,
	Thomas Munro <thomas.munro@gmail.com>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	Ibrar Ahmed <ibrar.ahmad@gmail.com>,
	Amit Khandekar <amitdkhan.pg@gmail.com>, fabriziomello@gmail.com,
	tushar <tushar.ahuja@enterprisedb.com>,
	Rahila Syed <rahila.syed@2ndquadrant.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Minimal logical decoding on standbys
Message-ID: <20230402213506.ocprj6ky45s4ydtr@awork3.anarazel.de>
References: <a4c03fad-2986-ddab-c12e-ea2ee0119181@gmail.com>
 <2d314c22b9e03415aa1c7d8fd1f698dae60effa7.camel@j-davis.com>
 <061eeb26-156e-6011-02b6-b4b1422e2aa6@gmail.com>
 <ec744999afcdbd6bec5d9e6572aba875060019cb.camel@j-davis.com>
 <8a7da0c2-b7fe-1c78-4e47-a16239bf4839@gmail.com>
 <d29e4458e7406b276c50197d9f3b31a5247fe915.camel@j-davis.com>
 <6ab352de1553c1e3d0c7d97c038dc470ca51e772.camel@j-davis.com>
 <4df984c8-3adb-3b69-0e4e-a491097862ce@gmail.com>
 <c188da88-a3d5-15c5-b6b5-f925abccc873@gmail.com>
 <bda73929475de2cb791a69f88d5d1e373e449478.camel@j-davis.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <bda73929475de2cb791a69f88d5d1e373e449478.camel@j-davis.com>
Archived-At: <https://www.postgresql.org/message-id/20230402213506.ocprj6ky45s4ydtr%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2023-03-31 02:44:33 -0700, Jeff Davis wrote:
> From 2f05cab9012950ae9290fccbb6366d50fc01553e Mon Sep 17 00:00:00 2001
> From: Jeff Davis <jeff@j-davis.com>
> Date: Wed, 1 Mar 2023 20:02:42 -0800
> Subject: [PATCH v2] Introduce ConditionVariableEventSleep().
> 
> The new API takes a WaitEventSet which can include socket events. The
> WaitEventSet must have been created by
> ConditionVariableWaitSetCreate(), another new function, so that it
> includes the wait events necessary for a condition variable.

Why not offer a function to add a CV to a WES? It seems somehow odd to require
going through condition_variable.c to create a WES.

Greetings,

Andres Freund