Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pjPXo-0006dX-Tm for pgsql-hackers@arkaria.postgresql.org; Mon, 03 Apr 2023 19:08:44 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pjPXn-0000PL-Ra for pgsql-hackers@arkaria.postgresql.org; Mon, 03 Apr 2023 19:08:43 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pjPXn-0000P4-IU for pgsql-hackers@lists.postgresql.org; Mon, 03 Apr 2023 19:08:43 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pjPXl-00072q-7E for pgsql-hackers@postgresql.org; Mon, 03 Apr 2023 19:08:42 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 4C7195C01DA; Mon, 3 Apr 2023 15:08:40 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 03 Apr 2023 15:08:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1680548920; x=1680635320; bh=el qon8j6AUUaUF/nl61SGap7fddJ/SanNSkfKS1nJDg=; b=YnyDCRP1SHMjS31N2C 1v5+91tkTCah6BiFn4LUAMkI6jirJDhPFZ/DMIwe2U0EUPGGyMfwnRoOt+jxHlhv p7gLB5TEAE+Tlrpk6kPJSzLBOixrz62Lje8vbomNxK1XiH349xMtZLchu5/MJ23L D0+FMsoRHvon+PljaDIGcwbjyGgowo7UHW30kDEbe8NzPvF2MtLWlEPF7i2Cp1x6 WZvnKmG1vhyZ0n21JpvDdDT4RUZxrwERmCArcM75lBOvHDcvY7OMV+aX/FtqWdhR oRNCsF1oNkTNGiu/9WIdxAYt7SEgA6M8yej2fBLTl9Z3oimsxxj7yxtRBtexgqBT QwKg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1680548920; x=1680635320; bh=elqon8j6AUUaU F/nl61SGap7fddJ/SanNSkfKS1nJDg=; b=T+iMu/Uo6Z6amtb0xnbVqUOBEpcrN +azqyzwZItypRseNIKB0NsiiIwWqQmObonPRWT6PY9eGSKJqNsidoudkVtVzel7w RRZ8eTgMPJVhY5eS7Q2hYsz0vusRfDdRQPs7TSDMhUO7h5y1pqAFuyyeFsQrddpk suO4og4F71fp7xkdOUJB6gm9qHfDpEr5AsYVxK4HUM/7kLMNPRvRFYB/voK/f6a/ wdILSYCcnXKJAql0vPFAJrB6eqU45jVRFmdGQtBarjrNyjeGykPDABeoxCd/dhaL YOq49tDcm4Z0E0kDdLDIrSV5BEjOnvn1Owdj7vA0f17pxAJu4eH8QnwmQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeijedgudefgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgu rhgvshcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtf frrghtthgvrhhnpedvffefvefhteevffegieetfefhtddvffejvefhueetgeeludehteev udeitedtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpegrnhgurhgvshesrghnrghrrgiivghlrdguvg X-ME-Proxy: Feedback-ID: id4a34324:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 3 Apr 2023 15:08:39 -0400 (EDT) Date: Mon, 3 Apr 2023 12:08:37 -0700 From: Andres Freund To: Tom Lane Cc: Melanie Plageman , Masahiko Sawada , Daniel Gustafsson , Kyotaro Horiguchi , PostgreSQL Hackers , amit.kapila16@gmail.com Subject: Re: Should vacuum process config file reload more often Message-ID: <20230403190837.qubpnwugfe2k2g46@awork3.anarazel.de> References: <20230329.132155.629765142788133576.horikyota.ntt@gmail.com> <20230329.173456.1185961934810139447.horikyota.ntt@gmail.com> <935191FB-083B-4060-89FC-466F61FAA391@yesql.se> <1252075.1680547394@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1252075.1680547394@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, On 2023-04-03 14:43:14 -0400, Tom Lane wrote: > Melanie Plageman writes: > > v13 attached with requested updates. > > I'm afraid I'd not been paying any attention to this discussion, > but better late than never. I'm okay with letting autovacuum > processes reload config files more often than now. However, > I object to allowing ProcessConfigFile to be called from within > commands in a normal user backend. The existing semantics are > that user backends respond to SIGHUP only at the start of processing > a user command, and I'm uncomfortable with suddenly deciding that > that can work differently if the command happens to be VACUUM. > It seems unprincipled and perhaps actively unsafe. I think it should be ok in commands like VACUUM that already internally start their own transactions, and thus require to be run outside of a transaction and at the toplevel. I share your concerns about allowing config reload in arbitrary places. While we might want to go there, it would require a lot more analysis. Greetings, Andres Freund