Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pk7IE-0003SA-UR for pgsql-hackers@arkaria.postgresql.org; Wed, 05 Apr 2023 17:51:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pk7IC-0006mL-Uc for pgsql-hackers@arkaria.postgresql.org; Wed, 05 Apr 2023 17:51:32 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pk7IC-0006mC-Jl for pgsql-hackers@lists.postgresql.org; Wed, 05 Apr 2023 17:51:32 +0000 Received: from mail-oi1-x229.google.com ([2607:f8b0:4864:20::229]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1pk7I9-0015of-AU for pgsql-hackers@postgresql.org; Wed, 05 Apr 2023 17:51:31 +0000 Received: by mail-oi1-x229.google.com with SMTP id bj20so27244429oib.3 for ; Wed, 05 Apr 2023 10:51:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680717086; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=zhX6mIusOO2ThJOdl6MTr8wbq6wfTJyX7AMZz4xZn1s=; b=cx+VmbVIXT9kY9Wi/m5Pnh5OU/XanIuepnrpr1vSpTi3+bpCTXr0tng352k/S284PP 1aUG7jK8122VZNqqf+7N7CBZCcCTi2tnuRM/zKntuOwo+ZxOKMF2SnMnDLR+dKpiU4Lu LCPJX0cj8iiwwT3MFfiFSFFc50tD7igoC0vq5Oq+pimYmUX7Ri9sdc2AOil62xgSBTtz 5O+389BK7eL8s8KU6qDVioZABsGh9Uk5Y6X+08aMayb5cSIn4QFlzYZZkXhiWAruXGx0 q3eXHjI2/X1ddDMO07Evqr7aAuO7b94/RehZQmGgLurHnsFMxoBJg95xFcQ15u1spEdC TfAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680717086; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zhX6mIusOO2ThJOdl6MTr8wbq6wfTJyX7AMZz4xZn1s=; b=QAMlJ0zTQN6yPksMywU5Z5LCajGs5I/xCGU0033vAv9g1UTcDwF38v6uBSVQim3u00 xMZR3MHtsmkJ+dUIdn+8G242elwCUJCJU3uIiuYCEyKBmGZ39F/beQzCf9NK4d8koMEw jkX/djRcGYFDmfazjVFL5PsTr0Lj/gK4xHVsUjQlG9EW2oFT8ULCXEl4uDsUFw0bTXcY IYTFpyrk+TyM6rNaXGNNA8BjrEIscL9lRSyT+s+tow8MPrY4SmZtrMO/0boXrxNRrWWP E4HseuAIkbbFt4Da9W1d9KGBDKaX+q5voD8Ym0NaDa4yjtd5wJuZnZzQu2VIIr6ASrcT juFw== X-Gm-Message-State: AAQBX9eDL3/gl67qYsFz9NsQNj1yhnsz5QQUz0cRCOBXFlQHt7wceQKo mjRr+7BIRnrPinHYLgQvpfk= X-Google-Smtp-Source: AKy350avw9+OKUCIicnDDQEQWgpoIjeCt6sdcELdLqn0k0aRmIwKHm4FJo74DVZoTJKynlEW6CDcHQ== X-Received: by 2002:a05:6808:3c5:b0:389:7b6b:7a31 with SMTP id o5-20020a05680803c500b003897b6b7a31mr3252914oie.43.1680717086565; Wed, 05 Apr 2023 10:51:26 -0700 (PDT) Received: from nathanxps13 ([2600:1700:48f8:340f:9bd8:a4a5:de85:9a21]) by smtp.gmail.com with ESMTPSA id et18-20020a056808281200b003872148d322sm6529902oib.22.2023.04.05.10.51.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 10:51:26 -0700 (PDT) Date: Wed, 5 Apr 2023 10:51:24 -0700 From: Nathan Bossart To: Robert Haas Cc: Andres Freund , pgsql-hackers@postgresql.org, schneider@ardentperf.com Subject: Re: monitoring usage count distribution Message-ID: <20230405175124.GA31516@nathanxps13> References: <20230130233040.GA2800702@nathanxps13> <20230404232919.uibzbhjdylk3mlvp@awork3.anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, Apr 05, 2023 at 09:44:58AM -0400, Robert Haas wrote: > On Tue, Apr 4, 2023 at 7:29 PM Andres Freund wrote: >> > Replacing that with a six-element integer array would be a clear improvement >> > and, IMHO, better than adding yet another function to the extension. >> >> I'd have no issue with that. > > Cool. The six-element array approach won't show the number of dirty and pinned buffers for each usage count, but I'm not sure that's a deal-breaker. Barring objections, I'll post an updated patch shortly with that approach. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com