Feedback-ID: id4a34324:Fastmail
Date: Mon, 10 Apr 2023 15:32:19 -0700
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Magnus Hagander <magnus@hagander.net>,
	Robert Haas <robertmhaas@gmail.com>, pgsql-hackers@postgresql.org,
	Peter Geoghegan <pg@bowt.ie>, Andrew Dunstan <andrew@dunslane.net>,
	"Jonathan S. Katz" <jkatz@postgresql.org>,
	Amit Kapila <amit.kapila16@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>
Subject: Re: When to drop src/tools/msvc support
Message-ID: <20230410223219.4tllxhz3hgwhh4tm@awork3.anarazel.de>
References: <20230408191007.7lysd42euafwl74f@awork3.anarazel.de>
 <3611416.1680982220@sss.pgh.pa.us>
 <CA+TgmobY5DO3CX_kzjyFKEYg7vTdvoFJd=Y0qLabd8K3eAdf6Q@mail.gmail.com>
 <4179373.1681145767@sss.pgh.pa.us>
 <CABUevEyHnPPZg15vQpnUJoidxy9riQVgvCpJL8Zw1fW6YPhWJw@mail.gmail.com>
 <13868.1681159820@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <13868.1681159820@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/20230410223219.4tllxhz3hgwhh4tm%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2023-04-10 16:50:20 -0400, Tom Lane wrote:
> Yeah, I think that's the only feasible answer at this point.
> Maybe a month or two back we could have done differently,
> but there's not a lot of runway now.
> 
> Once we do drop src/tools/msvc from HEAD, we should make a point
> of reminding -packagers about it, in hopes that they'll work on
> the transition sooner than next May.

So the plan is:

- add note to docs in HEAD that the src/tools/msvc style of build is
  deprecated
- give -packagers a HEADS up, once the deprecation notice has been added to
  the docs
- have a patch ready to drop src/tools/msvc from HEAD once 16 has branched off
  (i.e. a polished version of what I posted upthread)

On IM Thomas made some point about CI - I wonder if we should add building 16
with src/tools/msvc as an optional CI task? We can't enable it by default
(yet), because we'd not have enough resources to also run that for cfbot. Once
16 forked, we then could set to run automatically in the 16 branch, as cfbot
won't run those.

Greetings,

Andres Freund