Feedback-ID: id4a34324:Fastmail
Date: Tue, 11 Apr 2023 09:23:05 -0700
From: Andres Freund <andres@anarazel.de>
To: Dave Page <dpage@pgadmin.org>
Cc: Magnus Hagander <magnus@hagander.net>,
	Robert Haas <robertmhaas@gmail.com>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Amit Kapila <amit.kapila16@gmail.com>,
	Andrew Dunstan <andrew@dunslane.net>,
	"Jonathan S. Katz" <jkatz@postgresql.org>,
	Peter Geoghegan <pg@bowt.ie>, Tom Lane <tgl@sss.pgh.pa.us>,
	pgsql-hackers@postgresql.org
Subject: Re: When to drop src/tools/msvc support
Message-ID: <20230411162305.cksp3a6ouha3vmwb@awork3.anarazel.de>
References: <20230408191007.7lysd42euafwl74f@awork3.anarazel.de>
 <3611416.1680982220@sss.pgh.pa.us>
 <CA+TgmobY5DO3CX_kzjyFKEYg7vTdvoFJd=Y0qLabd8K3eAdf6Q@mail.gmail.com>
 <4179373.1681145767@sss.pgh.pa.us>
 <CA+TgmoZwJ09Aw_igiLV7J-OPikii5PyW_iJyXCFtS1MdcY7hJQ@mail.gmail.com>
 <CA+OCxoxCZ2Q4vz0oznYqDgU4aZYv0GXO4TytkD070OjUp0OJeQ@mail.gmail.com>
 <20230410222738.57fdxwdrdhwatnr4@awork3.anarazel.de>
 <CABUevEzX1xVDS=tV_MTNcPhJZXZSvXCZVBLp_gv=_kpPPhE-BQ@mail.gmail.com>
 <CA+OCxowwwJy4KP3+MrQVBHX5A9Ymb8W2Xt6vH_VvgUY6tiOL8Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CA+OCxowwwJy4KP3+MrQVBHX5A9Ymb8W2Xt6vH_VvgUY6tiOL8Q@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/20230411162305.cksp3a6ouha3vmwb%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2023-04-11 09:05:31 +0100, Dave Page wrote:
> Probably my main concern is that the Meson build can use the same version
> of the VC++ compiler that we use (v14), which is carefully matched for
> compatibility with all the various components, just in case anything passes
> CRT pointers around.

FWIW, Independent of meson, I don't think support for VC 2015 in postgres is
long for the world. Later versions of msvc have increased the C standard
compliance a fair bit... It's also a few years out of normal support.

I've not tested building with 2015, but I don't know of anything that should
prevent building with meson with it.  I am fairly sure that it can't build
tab-complete.c, but you're presumably not building with tab completion support
anyway?

Greetings,

Andres Freund