Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pmKv7-0000VG-Hm
	for pgsql-hackers@arkaria.postgresql.org; Tue, 11 Apr 2023 20:48:53 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pmKv5-0003pS-Dc
	for pgsql-hackers@arkaria.postgresql.org; Tue, 11 Apr 2023 20:48:51 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <andres@anarazel.de>)
	id 1pmKv5-0003pI-0F
	for pgsql-hackers@lists.postgresql.org; Tue, 11 Apr 2023 20:48:51 +0000
Received: from wout2-smtp.messagingengine.com ([64.147.123.25])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <andres@anarazel.de>)
	id 1pmKv2-0007ws-Hv
	for pgsql-hackers@lists.postgresql.org; Tue, 11 Apr 2023 20:48:49 +0000
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
	by mailout.west.internal (Postfix) with ESMTP id EED37320025E;
	Tue, 11 Apr 2023 16:48:46 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
  by compute5.internal (MEProxy); Tue, 11 Apr 2023 16:48:47 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h=
	cc:cc:content-type:content-type:date:date:from:from:in-reply-to
	:in-reply-to:message-id:mime-version:references:reply-to:sender
	:subject:subject:to:to; s=fm3; t=1681246126; x=1681332526; bh=eB
	82EMe0I5bMjKYqHIMYRO09JImliCjFyx5VUbZeySY=; b=bOY5gc7ffb9j9DG8Uj
	PjfVR8GUxn4IgJUoM6O2LERC7pXeQqqffeoQqyTptVACednEpToHZEFqzAHvxDMZ
	N6FPKC47LuiJHTZX9rvqVupmASxOUCLpDAAeibsZERXJxdiuv0fDXAgHfPzhen8x
	viswQHOPrxQuSsksaEjRfEWORCh+nrFsmw5+B0/y+odf3+59EzB58BjErFVR1hIk
	3hx90hqu24cmI5dCF2jeUS2Z1ftq0N9z7GC4BUi7CVZ3iNmF8HcuSyJuWNn/m+SQ
	Ym91QStCqZ/+AFUvnxrurBXygIqmSAG6I35ldtrxFwN0hxrqDsk3KMFkA91ctMlE
	azCw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:cc:content-type:content-type:date:date
	:feedback-id:feedback-id:from:from:in-reply-to:in-reply-to
	:message-id:mime-version:references:reply-to:sender:subject
	:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
	:x-sasl-enc; s=fm3; t=1681246126; x=1681332526; bh=eB82EMe0I5bMj
	KYqHIMYRO09JImliCjFyx5VUbZeySY=; b=VaZHuHr7+C1aPNI4YM4n15DYX+es+
	ZkQYdQhlsci4CGq1I7DsKdMP1uUEgh3QCcZVLbq+algZYoDzy7QiCHWlbIzrFVEt
	lxv7u2k62ZMjqEmll+Cz++I0QtbCFGSQmqjcUNkDhHhuPVZvG4nL9teg1SBrTSfs
	QBtvDG0ZlTMxXx2acgSVmJDiq3AJof5OSkFoCvZdFpkAxIinoZw10646J7w6nhSi
	6qnyDNH257GtWbTooTqV7WweX6QCWe+iPSG3Z5Y+0Isl7FvnDzZeoMJeMPq63p5M
	qqEdUxVg4UmCwkc4VzoalWgdKV+P7SqcGPVHwR+Ix9yxAocnJpVKUla/w==
X-ME-Sender: <xms:rcc1ZEL0jw7lU64yDMbuXnanXM7PWkerkQXo-N-1zUrKEn2RdxXxVQ>
    <xme:rcc1ZEJojDlHA4Wxga7hBEoHmvRIvlxrjvwheYCmOXw0Ul7kqoNP00GSTCWNp3c4N
    f_e8T2vXBGRi_C_9A>
X-ME-Received: <xmr:rcc1ZEsIrPYDVDHRL3sdefvwzZL-U4DBtalbkftNmE4LYE4cBfiBZHrpmMDPXvhKDtbqP0C1634Rfy3c_f0hqO4XXbYisIdNAJSYtNDWZbpXdo5hpWXvu7H_LOj->
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekgedgudehgecutefuodetggdotefrod
    ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
    necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
    enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgu
    rhgvshcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtf
    frrghtthgvrhhnpedvffefvefhteevffegieetfefhtddvffejvefhueetgeeludehteev
    udeitedtudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh
    hmpegrnhgurhgvshesrghnrghrrgiivghlrdguvg
X-ME-Proxy: <xmx:rsc1ZBZWuoqyYmvO29QLIw3oYuldDYeu075bxebyrM-Ly0C_KOTzIw>
    <xmx:rsc1ZLYvOidWkdrYVD52RFzr7NEsuaDn96Rv5YPUSwZhGaj76VBzQg>
    <xmx:rsc1ZNBwUkvUCAIAZf_05KhHbeF-IJB2rO1AztJ_ExGY3ToU1ACOCg>
    <xmx:rsc1ZCzOAdTfZklmJaoU8dZcRN9lkFJTE6X4IwCz4x9x_Vh1YP4jkw>
Feedback-ID: id4a34324:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 11 Apr 2023 16:48:45 -0400 (EDT)
Date: Tue, 11 Apr 2023 13:48:44 -0700
From: Andres Freund <andres@anarazel.de>
To: Peter Geoghegan <pg@bowt.ie>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>
Subject: Re: infobits_set WAL record struct field is int8
Message-ID: <20230411204844.lbv2cqn6azepqswh@awork3.anarazel.de>
References: <CAH2-WzkCd3kOS8b7Rfxw7Mh1_6jvX=Nzo-CWR1VBTiOtVZkWHA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAH2-WzkCd3kOS8b7Rfxw7Mh1_6jvX=Nzo-CWR1VBTiOtVZkWHA@mail.gmail.com>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/20230411204844.lbv2cqn6azepqswh%40awork3.anarazel.de>
Precedence: bulk

Hi,

On 2023-04-11 13:13:49 -0700, Peter Geoghegan wrote:
> Commit 0ac5ad5134 ("Improve concurrency of foreign key locking") added
> infobits_set fields to certain WAL records. However, in the case of
> xl_heap_lock, it made the data type int8 rather than uint8.
>
> I believe that this was a minor oversight. Attached patch fixes the issue.

Makes sense. Looks like there never was a flag defined for the sign bit,
luckily. I assume you're just going to apply this for HEAD?

Greetings,

Andres Freund