Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pnNRl-0000ts-4y
	for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Apr 2023 17:42:53 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pnNRj-0005tz-I7
	for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Apr 2023 17:42:51 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <kop@karlpinc.com>)
	id 1pnNRj-0005tq-8l
	for pgsql-hackers@lists.postgresql.org; Fri, 14 Apr 2023 17:42:51 +0000
Received: from janus.karlpinc.com ([173.161.46.12] helo=smtp.karlpinc.com)
	by magus.postgresql.org with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <kop@karlpinc.com>)
	id 1pnNRb-002txL-IE
	for pgsql-hackers@postgresql.org; Fri, 14 Apr 2023 17:42:50 +0000
Received: from slate.karlpinc.com (unknown [192.168.1.14])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by smtp.karlpinc.com (Postfix) with ESMTPS id 0803AA0F1;
	Fri, 14 Apr 2023 12:42:37 -0500 (CDT)
Received: from slate.karlpinc.com (localhost [IPv6:::1])
	by slate.karlpinc.com (Postfix) with ESMTPS id 6552A3FC11;
	Fri, 14 Apr 2023 12:42:35 -0500 (CDT)
Date: Fri, 14 Apr 2023 12:41:23 -0500
From: "Karl O. Pinc" <kop@karlpinc.com>
To: Brar Piening <brar@gmx.de>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Alvaro Herrera
 <alvherre@alvh.no-ip.org>, Tom Lane <tgl@sss.pgh.pa.us>, vignesh C
 <vignesh21@gmail.com>, Ian Lawrence Barwick <barwick@gmail.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: doc: add missing "id" attributes to extension packaging page
Message-ID: <20230414124123.7784ab00@slate.karlpinc.com>
In-Reply-To: <20230413105331.6d0a7db9@slate.karlpinc.com>
References: <20230323093555.3icw7zetwtmtrrzu@alvherre.pgsql>
	<a41ed60d-2f95-da52-ba8b-b0b1cc37f3a4@gmx.de>
	<184dc41b-7407-1bb9-7fd4-7fb35db8b993@enterprisedb.com>
	<c6690867-4b06-ad16-b784-4824fcd4d43a@gmx.de>
	<cea67271-ef9f-6c94-e303-bf9269ef6f35@enterprisedb.com>
	<91edf03b-7b63-67b6-7f44-bfeb48e97056@gmx.de>
	<8c745b14-9443-274d-5900-db3f276ee293@enterprisedb.com>
	<90cf1be5-19cb-e2e9-756b-02df52a99cfb@gmx.de>
	<20230413105331.6d0a7db9@slate.karlpinc.com>
X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/20230414124123.7784ab00%40slate.karlpinc.com>
Precedence: bulk

On Thu, 13 Apr 2023 10:53:31 -0500
"Karl O. Pinc" <kop@karlpinc.com> wrote:

> On Thu, 13 Apr 2023 16:01:35 +0200
> Brar Piening <brar@gmx.de> wrote:
>=20
> > On 13.04.2023 at 10:31, Peter Eisentraut wrote: =20

> > > Side project: I noticed that these new hover links don't appear in
> > > the single-page HTML output (make postgres.html), even though the
> > > generated HTML source code looks correct.=C2=A0 Maybe someone has an
> > > idea there.   =20
> > I feel responsible for the feature to work for all use cases where
> > it makes sense. I'll investigate this and post back. =20
>=20
> Looks to me like the ">" in the CSS was transformed into the &gt;
> HTML entity when the stylesheet was included into the single-file
> HTML.

The XSLT 1.0 spec says that characters in <style> elements should
not be escaped when outputting HTML.  [4]  But (I think) the
generate.css.header parameter method [1][2] of=20
inserting the CSS into the HTML expands the CSS content
in an XML context, not a HTML context. =20

I've played around with it, going so far as to make stylesheet.css
look like:

--------------<snip>--------
<!DOCTYPE  xsl:stylesheet [
<!ENTITY css SYSTEM "stylesheet.css">
]>
<xsl:stylesheet
  xmlns:xsl=3D"http://www.w3.org/1999/XSL/Transform">
  &css;
</xsl:stylesheet>
--------------<snip>--------

and even substituted the actual text of stylesheet.css in
place of the &css; entity reference.  In these cases the
"<" character is still entity expanded, resulting in broken CSS.

My conclusion is that this method is broken.

(The other possibility, I suppose, is that xsltproc is broken.)

I think the thing to try is the sagehill.net approach [4].
This overrides the user.head.content template.  My hope is
that because the &css; entity is seen in a <style> element
in the template, that xsltproc then recognizances style element
content in a HTML output context.

(I don't know how xsltproc is supposed to know that it is
in a HTML output context.  I suppose exploring this would
be another avenue should the above fail.)


1
https://docbook.sourceforge.net/release/xsl/current/doc/html/custom.css.sou=
rce.html

2
https://docbook.sourceforge.net/release/xsl/current/doc/html/generate.css.h=
eader.html

3 http://sagehill.net/docbookxsl/HtmlHead.html#EmbedCSS

4 https://www.w3.org/TR/xslt-10/#section-HTML-Output-Method

Regards,

Karl <kop@karlpinc.com>
Free Software:  "You don't pay back, you pay forward."
                 -- Robert A. Heinlein