Date: Thu, 20 Apr 2023 12:56:32 +0900 (JST)
Message-Id: <20230420.125632.236796436425209579.horikyota.ntt@gmail.com>
To: michael@paquier.xyz
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: eclg -C ORACLE breaks data
From: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
In-Reply-To: <ZD4B5Ixtc0cGuAbL@paquier.xyz>
References: <20230410.173500.440060475837236886.horikyota.ntt@gmail.com>
	<ZDz8u6Aswu3PGn33@paquier.xyz>
	<ZD4B5Ixtc0cGuAbL@paquier.xyz>
User-Agent: Mew version 6.8 on Emacs 27.2
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/20230420.125632.236796436425209579.horikyota.ntt%40gmail.com>
Precedence: bulk

At Tue, 18 Apr 2023 11:35:16 +0900, Michael Paquier <michael@paquier.xyz> wrote in 
> On Mon, Apr 17, 2023 at 05:00:59PM +0900, Michael Paquier wrote:
> > This thinko has been introduced by 3b7ab43, so this needs to go down
> > to v11.  I'll see to that.
> 
> So done.  mylodon is feeling unhappy about that, because this has a

Thanks!

> C99 declaration:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=mylodon&dt=2023-04-18%2002%3A22%3A04
> char_array.pgc:73:8: error: variable declaration in for loop is a C99-specific feature [-Werror,-Wc99-extensions]
>   for (int i = 0 ; i < sqlda->sqld ; i++)
> 
> I'll go fix that in a minute, across all the branches for
> consistency.

Oh, I didn't realize there were differences in the
configurations. Good to know.

regards.

-- 
Kyotaro Horiguchi
NTT Open Source Software Center