Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ppaiw-0005Te-33
	for pgsql-hackers@arkaria.postgresql.org; Thu, 20 Apr 2023 20:17:46 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ppaiu-0006XC-A7
	for pgsql-hackers@arkaria.postgresql.org; Thu, 20 Apr 2023 20:17:44 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <nathandbossart@gmail.com>)
	id 1ppaiu-0006X3-0M
	for pgsql-hackers@lists.postgresql.org; Thu, 20 Apr 2023 20:17:44 +0000
Received: from mail-pf1-x42e.google.com ([2607:f8b0:4864:20::42e])
	by magus.postgresql.org with esmtps  (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256
	(Exim 4.94.2)
	(envelope-from <nathandbossart@gmail.com>)
	id 1ppair-0046GQ-DS
	for pgsql-hackers@lists.postgresql.org; Thu, 20 Apr 2023 20:17:43 +0000
Received: by mail-pf1-x42e.google.com with SMTP id
 d2e1a72fcca58-63b67a26069so2019614b3a.0
        for <pgsql-hackers@lists.postgresql.org>;
 Thu, 20 Apr 2023 13:17:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20221208; t=1682021859; x=1684613859;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;
        bh=pCnM6NG5tmCW6OA1zKjRIc3hLZW1yo/j3yN94kBwID8=;
        b=KHtX76nWn0NS3d+ZPnLQ3utwt8UhtXavkuKWc664+koJ92SwTF2hwdQ6RMyTxreKQ0
         v5bUzvibi5QcBnC7oKh/SiA0IRzg9UL2Ttm3YTIKczPE0aS52V45rkHaZst6rbZVPHGF
         IqpDbKJSJJppbZCXo1ieVstWQ8/p5mS6dVzvZHDaQGAj4y6PcScdkD/XRfzrhHpo3UqD
         Aa1P2cvxEkMPibQvWK1MgRRz9P1XLGULV3oAFh4YGcSeYizQvLfNSONpldZaHeSVXbqh
         tuEbNib/IB8glpsDFRtKpDm0MH+1wosHTDiRRNdV0n2JHqzXL5eMgpIpcog56CjGlXy1
         6vbg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20221208; t=1682021859; x=1684613859;
        h=in-reply-to:content-disposition:mime-version:references:message-id
         :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=pCnM6NG5tmCW6OA1zKjRIc3hLZW1yo/j3yN94kBwID8=;
        b=IQ+nYTBOxS+V9ttVwF/kX+4RMYx1ry1mRLTQ2lBL1ovfLu26cRmO0SvrZv8XXGPjjY
         gJQWGkQ5ISGVGJPdPFfzdyWsLGrViVVSuOpMmiUaw3Y9Zlfbl7Tw7NH/rlVjTitnGAx9
         NbH5oagoy8aQuhj+AnEb6j9CODhyqAi3Dl4ObGFNOEXSlDisRkX9JnximaIyoezKbKgU
         Ox7vcB84jd/iAp1X4EUHWFTa8CbGSV3VXu3QEy/LGL7VN+vDtJAwfu8GyfLQDejVcYhn
         if2qW8zO9rnlnKEgn0z6kss6mWYovYKKQEFfRw+diJmgCAFLCdrRAsShKjAGOQgSq4YD
         oO2Q==
X-Gm-Message-State: AAQBX9e/sxI2jeOtTn17z+bvZpmnZTqSF+LPjWqsySWqO59BkcQY9Hl0
	urRbZhpWAURLLlRHPJtkdpM=
X-Google-Smtp-Source: 
 AKy350bgDto+84nIj639RBnBrxLB+Dm1uBTxSFazMW6jWf6MWmoxr9rJm6FRYvObBwJ0kmE76X+XAA==
X-Received: by 2002:a05:6a20:9185:b0:ef:a31b:af86 with SMTP id
 v5-20020a056a20918500b000efa31baf86mr3563829pzd.27.1682021858611;
        Thu, 20 Apr 2023 13:17:38 -0700 (PDT)
Received: from nathanxps13 ([50.47.162.83])
        by smtp.gmail.com with ESMTPSA id
 i24-20020aa78d98000000b005a9ea5d43ddsm1669508pfr.174.2023.04.20.13.17.37
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Thu, 20 Apr 2023 13:17:38 -0700 (PDT)
Date: Thu, 20 Apr 2023 13:17:36 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jim Jones <jim.jones@uni-muenster.de>,
	Ken Kato <katouknl@oss.nttdata.com>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: Tab completion for GRANT MAINTAIN
Message-ID: <20230420201736.GA1367372@nathanxps13>
References: <6afe7712991882a864d6d10003264e7c@oss.nttdata.com>
 <a8ae0f8b-8ecb-a3f5-0c1b-bcb4bda1c80a@uni-muenster.de>
 <2977470.1681916045@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2977470.1681916045@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/20230420201736.GA1367372%40nathanxps13>
Precedence: bulk

On Wed, Apr 19, 2023 at 10:54:05AM -0400, Tom Lane wrote:
> (One could wish that it didn't take touching three or so places in
> tab-complete.c to add a privilege, especially when a naive hacker might
> think he was done after touching Privilege_options_of_grant_and_revoke.
> I didn't see any easy way to improve that situation though.)

Sorry, I think this was my fault.  Thanks for fixing.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com