Date: Thu, 20 Apr 2023 14:16:17 -0700
From: Nathan Bossart <nathandbossart@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>, sfrost@snowman.net,
	alvherre@alvh.no-ip.org, andres@anarazel.de,
	jchampion@timescale.com, john.naylor@enterprisedb.com,
	masao.fujii@oss.nttdata.com, noriyoshi.shinoda@hpe.com,
	pgsql-hackers@postgresql.org, rjuju123@gmail.com,
	sawada.mshk@gmail.com, tgl@sss.pgh.pa.us, thomas.munro@gmail.com
Subject: Re: Improve logging when using Huge Pages
Message-ID: <20230420211617.GA1435672@nathanxps13>
References: <ZBfsbTEUnRcEyNao@paquier.xyz>
 <ZBplvQx7n0MGVr6O@telsasoft.com>
 <ZBqwHY7yZQATAp9N@paquier.xyz>
 <ZBt+tCS/Akj8BvHi@telsasoft.com>
 <ZBt/4EdbwLp2hJLx@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZBt/4EdbwLp2hJLx@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/20230420211617.GA1435672%40nathanxps13>
Precedence: bulk

On Thu, Mar 23, 2023 at 07:23:28AM +0900, Michael Paquier wrote:
> On Wed, Mar 22, 2023 at 05:18:28PM -0500, Justin Pryzby wrote:
>> Wow, good point.  I think to make it work we'd need put
>> huge_pages_active into BackendParameters and handle it in
>> save_backend_variables().  If so, that'd be strong argument for using a
>> GUC, which already has all the necessary infrastructure for exposing the
>> server's state.
> 
> I am afraid so, duplicating an existing infrastructure for a need like
> the one of this thread is not really appealing.

AFAICT this would involve adding a bool to BackendParameters and using it
in save_backend_variables() and restore_backend_variables(), which is an
additional 3 lines of code.  That doesn't sound too bad to me, but perhaps
I am missing something.

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com